Bug 2314453
| Summary: | Review Request: rust-qcow2-rs - Rust library for read/write qcow2 image in async/await | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ming Lei <minlei> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | amulhern, bgurney, decathorpe, extras-qa, package-review, rjones |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/futures-locks | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 2305524 | Environment: | |
| Last Closed: | 2025-04-29 00:45:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2305524 | ||
| Bug Blocks: | 201449 | ||
|
Description
Ming Lei
2024-09-24 15:42:45 UTC
The `fedora-review` flag is set by the *reviewer*, not the *submitter*. Copr build: https://copr.fedorainfracloud.org/coprs/build/8066290 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314453-rust-qcow2-rs/fedora-rawhide-x86_64/08066290-rust-qcow2-rs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello Guys, Gentle ping... thanks, It looks like this package depends on a crate that was so old and unused in Fedora that I cleaned it up two days ago: https://src.fedoraproject.org/rpms/rust-crypto-hash Problem: nothing provides requested (crate(crypto-hash/default) >= 0.3.0 with crate(crypto-hash/default) < 0.4.0~) I try to avoid removing packages that are needed by packages that are pending review, but I obviously missed this one. Sorry! I'll get it added back soon. Hi Fabio, I saw rust-crypto-hash-0.3.4 is in rawhide, so can we move on with this BZ? Thanks, Yes, sorry about the delay. The package looks good, just one question: Is the rqcow2 executable useful and you explicitly want to ship it with the package, or do you only need the qcow2-rs crate for its library interface? If you do not need rcow2 executable, excluding it would make the package quite a bit simpler to maintain. Are you still interested in this package? If yes, please answer the question in my last comment and adjust the packaging, if you don't need the rqcow2 executable. You could make use of a rust2rpm.toml config file with these contents if you want to make this change: """ [package] cargo-install-bin = false """ This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |