Bug 2314532
| Summary: | Review Request: golang-github-nvidia-container-toolkit - Build and run containers leveraging NVIDIA GPUs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Debarshi Ray <debarshir> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-05 22:36:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Debarshi Ray
2024-09-25 01:02:14 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8067764 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314532-golang-github-nvidia-container-toolkit/fedora-rawhide-x86_64/08067764-golang-github-nvidia-container-toolkit/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I am thinking that the main golang-github-nvidia-container-toolkit package (not the -devel sub-package) should be installable as 'nvidia-container-toolkit' because it contains some user-facing binaries. I am considering adding a virtual Provides as in golang-github-cpuguy83-md2man: https://src.fedoraproject.org/rpms/golang-github-cpuguy83-md2man Updated with virtual Provides. This is needed for: https://src.fedoraproject.org/rpms/toolbox/pull-request/22 Thanks for adding all the comments in the spec, it makes much easier to understand why those extra things are required.
Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-nvidia-container-toolkit Requested Git repository: https://pagure.io/releng/fedora-scm-requests/issue/68186 Requested Git branches for f41, f40 and f39: https://pagure.io/releng/fedora-scm-requests/issue/68187 https://pagure.io/releng/fedora-scm-requests/issue/68188 https://pagure.io/releng/fedora-scm-requests/issue/68189 (In reply to Mikel Olasagasti Uranga from comment #5) > Thanks for adding all the comments in the spec, it makes much easier to > understand why those extra things are required. It took me a while to figure everything out all those details. :) > [...] > > Package approved! On import, don't forget to do the following: Thanks, Mikel. > - [ ] Add the package to release-monitoring.org > - [ ] Give go-sig privileges (at least commit) on the package > - [ ] Close the review bug by referencing its ID in the rpm changelog and > the Bodhi ticket. > - [ ] Consider configuring Packit service to help with maintenance Okay, I will do those. FEDORA-2024-f8053e1ea4 (golang-github-nvidia-container-toolkit-1.16.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f8053e1ea4 FEDORA-2024-2610b2899e (golang-github-nvidia-container-toolkit-1.16.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2610b2899e FEDORA-2024-a884b1b0ce (golang-github-nvidia-container-toolkit-1.16.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a884b1b0ce FEDORA-2024-a884b1b0ce has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a884b1b0ce \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a884b1b0ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-f8053e1ea4 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f8053e1ea4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f8053e1ea4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-2610b2899e has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2610b2899e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2610b2899e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Added https://github.com/NVIDIA/nvidia-container-toolkit to Anitya: https://release-monitoring.org/project/234913/ ... and enabled monitoring in Fedora: https://src.fedoraproject.org/rpms/golang-github-nvidia-container-toolkit FEDORA-2024-f8053e1ea4 (golang-github-nvidia-container-toolkit-1.16.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-a884b1b0ce (golang-github-nvidia-container-toolkit-1.16.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-2610b2899e (golang-github-nvidia-container-toolkit-1.16.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |