Bug 2314617

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8068527
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314617-python-huami-token/fedora-rawhide-x86_64/08068527-python-huami-token/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is still up for review.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 6 files have unknown license. Detailed output of
     licensecheck in /home/fedora-packaging/reviews/python-huami-
     token/2314617-python-huami-token/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14/site-
     packages, /usr/lib/python3.14
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 5683 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-huami-token-0.7.0-1.fc44.noarch.rpm
          python-huami-token-0.7.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpkig_5hd6')]
checks: 32, packages: 2

python-huami-token.src: E: spelling-error ('bluetooth', '%description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth')
python-huami-token.src: E: spelling-error ('cep', '%description -l en_US cep -> cap, rep, cop')
python-huami-token.src: E: spelling-error ('alm', '%description -l en_US alm -> lam, am, alms')
python-huami-token.src: E: spelling-error ('pak', '%description -l en_US pak -> oak, pal, pa')
python3-huami-token.noarch: E: spelling-error ('bluetooth', '%description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth')
python3-huami-token.noarch: E: spelling-error ('cep', '%description -l en_US cep -> cap, rep, cop')
python3-huami-token.noarch: E: spelling-error ('alm', '%description -l en_US alm -> lam, am, alms')
python3-huami-token.noarch: E: spelling-error ('pak', '%description -l en_US pak -> oak, pal, pa')
python3-huami-token.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/huami_token/huami_token.py 644 /usr/bin/env python3
python3-huami-token.noarch: W: no-manual-page-for-binary huami_token
 2 packages and 0 specfiles checked; 9 errors, 1 warnings, 7 filtered, 9 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-huami-token.noarch: E: spelling-error ('bluetooth', '%description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth')
python3-huami-token.noarch: E: spelling-error ('cep', '%description -l en_US cep -> cap, rep, cop')
python3-huami-token.noarch: E: spelling-error ('alm', '%description -l en_US alm -> lam, am, alms')
python3-huami-token.noarch: E: spelling-error ('pak', '%description -l en_US pak -> oak, pal, pa')
python3-huami-token.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/huami_token/huami_token.py 644 /usr/bin/env python3
python3-huami-token.noarch: W: no-manual-page-for-binary huami_token
 1 packages and 0 specfiles checked; 5 errors, 1 warnings, 3 filtered, 5 badness; has taken 0.1 s 



Source checksums
----------------
https://codeberg.org/argrento/huami-token/archive/v0.7.0.tar.gz#/huami_token-0.7.0.tar.gz :
  CHECKSUM(SHA256) this package     : 9a21d35a7c8f4eadf979436a8ef4ddfa306388f241d36ded08039474d7dcb81d
  CHECKSUM(SHA256) upstream package : 9a21d35a7c8f4eadf979436a8ef4ddfa306388f241d36ded08039474d7dcb81d


Requires
--------
python3-huami-token (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.14dist(requests)
    python3.14dist(types-requests)



Provides
--------
python3-huami-token:
    python-huami-token
    python3-huami-token
    python3.14-huami-token
    python3.14dist(huami-token)
    python3dist(huami-token)



Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora-packaging/reviews/python-huami-token/2314617-python-huami-token/srpm/python-huami-token.spec	2025-09-26 10:56:56.415665440 +0300
+++ /home/fedora-packaging/reviews/python-huami-token/2314617-python-huami-token/srpm-unpacked/python-huami-token.spec	2024-09-25 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.7.2)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 # test requires real credentials and network access
 %bcond_with check
@@ -56,3 +66,8 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Wed Sep 25 2024 Dominik Mierzejewski <dominik> - 0.7.0-1
+- initial package for Fedora
+- relax upstream dependencies
+- fix entrypoint script
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2314617
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Perl, Ocaml, Haskell, PHP, Java, C/C++, fonts, R, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Please add a link to:
https://codeberg.org/argrento/huami-token/pulls/84
above the associated patch in the spec file
b) Please remove:
%license LICENSE.md
from the spec file, license is already marked
 rpm -qL python3-huami-token-0.7.0-1.fc44.noarch.rpm
/usr/lib/python3.14/site-packages/huami_token-0.7.0.dist-info/licenses/LICENSE.md
and change
%pyproject_save_files huami_token
to
%pyproject_save_files -L huami_token
so that if the license file annotation is removed, an error is raised.
c) Approved. Please fix (a) and (b) before import.
/usr/share/licenses/python3-huami-token/LICENSE.md
d) REview of one of:
https://bugzilla.redhat.com/show_bug.cgi?id=2397149
https://bugzilla.redhat.com/show_bug.cgi?id=2397147
would be appreciated if time allows.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-huami-token

FEDORA-2025-c63eac6c4d (python-huami-token-0.7.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c63eac6c4d

FEDORA-2025-c63eac6c4d (python-huami-token-0.7.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.