Bug 2315416

Summary: Review Request: rust-zeitfetch - Instantaneous snapshots of system information
Product: [Fedora] Fedora Reporter: Alessio <alciregi>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/zeitfetch
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-16 17:16:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alessio 2024-09-28 07:41:06 UTC
Spec URL: https://alciregi.fedorapeople.org/rustrpm/rust-zeitfetch.spec
SRPM URL: https://alciregi.fedorapeople.org/rustrpm/rust-zeitfetch-0.1.13-1.fc41.src.rpm
Description: Instantaneous snapshots of cross-platform system information, like neofetch
Fedora Account System Username: alciregi

Comment 1 Alessio 2024-09-28 07:47:05 UTC
Successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=124091458

Comment 2 Fedora Review Service 2024-09-28 07:48:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8087349
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315416-rust-zeitfetch/fedora-rawhide-x86_64/08087349-rust-zeitfetch/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-10-15 12:49:16 UTC
I assume you've missed the two big FIXME items in the generated spec?

Please replace this:

```
# FIXME: paste output of %%cargo_license_summary here
License:        # FIXME
# LICENSE.dependencies contains a full license breakdown
```

With this:

```
# (MIT OR Apache-2.0) AND Unicode-DFS-2016
# Apache-2.0 OR BSL-1.0
# Apache-2.0 OR MIT
# BSD-3-Clause
# MIT
# MIT OR Apache-2.0
# Unlicense OR MIT
License:        MIT AND BSD-3-Clause AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Unlicense OR MIT)
# LICENSE.dependencies contains a full license breakdown
```

(The list of dependencies is printed to the build.log by the `%cargo_license_summary` macro.)

Comment 4 Alessio 2024-10-15 14:00:07 UTC
:facepalm:

I totally missed it or I uploaded the wrong file.

Comment 6 Fabio Valentini 2024-10-15 19:46:57 UTC
Thanks, looks good to me now!

Note that the "prettytable-rs" crate is pretty much dead, and it's already *slightly* broken with the latest versions of its dependencies.
Upstream might want to switch to a different library.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-10-16 07:29:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zeitfetch

Comment 8 Fedora Update System 2024-10-16 17:12:22 UTC
FEDORA-2024-e82881a000 (rust-zeitfetch-0.1.13-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e82881a000

Comment 9 Fedora Update System 2024-10-16 17:16:10 UTC
FEDORA-2024-e82881a000 (rust-zeitfetch-0.1.13-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-10-16 20:47:23 UTC
FEDORA-2024-ab6578c3a8 (rust-zeitfetch-0.1.13-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ab6578c3a8

Comment 11 Fedora Update System 2024-10-17 02:18:04 UTC
FEDORA-2024-ab6578c3a8 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ab6578c3a8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ab6578c3a8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-10-26 02:58:15 UTC
FEDORA-2024-ab6578c3a8 (rust-zeitfetch-0.1.13-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.