Bug 2315523
| Summary: | Review Request: rust-wl-nl80211 - Rust crate for linux nl80211(WIFI) netlink protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gris Ge <fge> |
| Component: | Package Review | Assignee: | Cristian Le <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | fedora:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/wl-nl80211 | ||
| Whiteboard: | |||
| Fixed In Version: | rust-wl-nl80211-0.2.0-1.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-09 13:28:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gris Ge
2024-09-29 06:54:46 UTC
Copr repo created https://copr.fedorainfracloud.org/coprs/cathay4t/fed-new-rpm-review/ confirming it is passing compilation on all supported Fedora version. Copr build: https://copr.fedorainfracloud.org/coprs/build/8091463 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315523-rust-wl-nl80211/fedora-rawhide-x86_64/08091463-rust-wl-nl80211/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. LGTM. This is a straightforward rust2rpm, and all seems fine. My additional suggestion is to add a blank `rust2rpm.toml` just to indicate that you've used all default values. Also could you mark the bugzilla bug that requires this package that is referenced in: > The new version 1.2.20 of existing nispor rpm introduced new dependency on rust crate -- wl-nl80211. Hence we need introduce its crate into fedora (Using Fabio's review template) === Package was generated with rust2rpm, simplifying the review. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (Upstream doesn't have any tests, other than examples compiling I guess) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wl-nl80211 Thanks for the review. RPM shipped to rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=124623761 FEDORA-2024-7745cf7dc7 (rust-wl-nl80211-0.2.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7745cf7dc7 FEDORA-2024-7745cf7dc7 (rust-wl-nl80211-0.2.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |