Bug 2315554

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8091464
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315554-python-gql/fedora-rawhide-x86_64/08091464-python-gql/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hello Steve,

gql-cli requires the aiohttp module, but python3-gql package does not require aiohttp, 
therefore i think aiohttp is not installed and fails to run gql-cli in my environment.
please recheck the package dependency is correct?

```
# echo 'query { continent(code:"AF") { name } }' | gql-cli https://countries.trevorblades.com
Traceback (most recent call last):
  File "/usr/bin/gql-cli", line 8, in <module>
    sys.exit(gql_cli())
             ~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/gql/cli.py", line 534, in gql_cli
    exit_code = loop.run_until_complete(main_task)
  File "/usr/lib64/python3.13/asyncio/base_events.py", line 720, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/gql/cli.py", line 436, in main
    transport = get_transport(args)
  File "/usr/lib/python3.13/site-packages/gql/cli.py", line 323, in get_transport
    from gql.transport.aiohttp import AIOHTTPTransport
  File "/usr/lib/python3.13/site-packages/gql/transport/aiohttp.py", line 9, in <module>
    import aiohttp
ModuleNotFoundError: No module named 'aiohttp'

```

Here is my fedora-review result.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 167 files have unknown license. Detailed output of
     licensecheck in /home/mockbuilder/2315554-python-gql/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13,
     /usr/lib/python3.13/site-packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4342 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-gql-3.5.0-1.fc42.noarch.rpm
          python-gql-3.5.0-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6ex7fulb')]
checks: 32, packages: 2

python-gql.src: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python-gql.src: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 13 filtered, 4 badness; has taken 0.5 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 8 filtered, 2 badness; has taken 0.3 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/gql/gql-3.5.0.tar.gz :
  CHECKSUM(SHA256) this package     : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9
  CHECKSUM(SHA256) upstream package : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9


Requires
--------
python3-gql (rpmlib, GLIBC filtered):
    (python3.13dist(anyio) < 5~~ with python3.13dist(anyio) >= 3)
    (python3.13dist(backoff) < 3~~ with python3.13dist(backoff) >= 1.11.1)
    (python3.13dist(graphql-core) < 3.3~~ with python3.13dist(graphql-core) >= 3.2)
    (python3.13dist(yarl) < 2~~ with python3.13dist(yarl) >= 1.6)
    /usr/bin/python3
    python(abi)



Provides
--------
python3-gql:
    python-gql
    python3-gql
    python3.13-gql
    python3.13dist(gql)
    python3dist(gql)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2315554
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Ocaml, Java, Haskell, Perl, SugarActivity, C/C++, fonts, R, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Thanks for review.

I have generated sub packages now with:

   %pyproject_extras_subpkg -n python3-gql aiohttp websockets requests httpx botocore

and it seems from the guidelines 

> If you create a dedicated subpackage and want it to be always/usually installed, you can Require/Recommend/Suggest it from the main package.

So have added an explicit requirement from the main package where the CLI is.

   Recommends:       python3-gql+aiohttp = %{version}-%{release}

Could not find a macro to do Recommends python3dist(gql[aiohttp]) = 3.8  ?

Happy to change to Requires of course.

This is similar to the aiohttp package itself.

New packages at same location.


Spec URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql-3.5.0-1.fc42.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8494936
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315554-python-gql/fedora-rawhide-x86_64/08494936-python-gql/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Also a question about:

> [!]: Packages should try to preserve timestamps of original installed
>     files.

Other than setup.py and tox.ini which are not deployed I don't see anything in particular?

Hi Steve, Thanks for the response.


> Spec URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql.spec
> SRPM URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql-3.5.0-1.fc42.src.rpm


Could you please check the files are latest? The spec files seem not to be same.

```
Diff spec file in url and in SRPM
---------------------------------
--- /home/build/dev/fedora_packaging/python-gql.spec    2025-01-09 17:58:52.000000000 +0000
+++ /home/build/dev/fedora_packaging/review-python-gql/srpm-unpacked/python-gql.spec    2024-09-29 00:00:00.000000000 +0000
@@ -21,14 +21,7 @@
 GQL architecture is inspired by React-Relay and Apollo-Client.
 
-%pyproject_extras_subpkg -n python3-gql aiohttp websockets requests httpx botocore
-
 %package -n     python3-%{pypi_name}
 Summary:        GraphQL client for Python
 
-# Explicit requires for /usr/bin/gql-cli
-# Surely there is a macro to do something like?
-# Recommends:    python3dist(gql[aiohttp]) = 3.8 
-Recommends:     python3-gql+aiohttp = %{version}-%{release}
-
 %description -n python3-%{pypi_name}
 This is a GraphQL client for Python 3.7+. Plays nicely with graphene,
```

The upstream project lists the aiohttp package in the "extras_require" section,                            
so using the "extras_subpkg" macro is a good idea. If an error occurs during                               
normal operation on Fedora despite aiohttp being an extra, I suggest submitting                            
a PR to move aiohttp to the "install_requires" section.  

As of timestamp, in my environment, the original timestamp of "gql/cli.py" is
```
$ tar -tvf review-python-gql/upstream/gql-3.5.0.tar.gz | grep "gql/cli.py"
-rw-r--r-- runner/docker 16695 2024-01-03 14:40 gql-3.5.0/gql/cli.py
```
on the other hand, the timestamp of installed "gql/cli.py" is
```
$ ls -l /usr/lib/python3.13/site-packages/gql/cli.py 
-rw-r--r-- 1 root root 16695 Jan 15 00:00 /usr/lib/python3.13/site-packages/gql/cli.py
```

Please check my review result.

```
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 167 files have unknown license. Detailed output of
     licensecheck in /home/build/dev/fedora_packaging/review-python-
     gql/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13/site-
     packages, /usr/lib/python3.13
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4342 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-gql-3.5.0-1.fc42.noarch.rpm
          python-gql-3.5.0-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk3zh9h_0')]
checks: 32, packages: 2

python-gql.src: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python-gql.src: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 13 filtered, 4 badness; has taken 2.7 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 8 filtered, 2 badness; has taken 1.0 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/gql/gql-3.5.0.tar.gz :
  CHECKSUM(SHA256) this package     : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9
  CHECKSUM(SHA256) upstream package : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9


Requires
--------
python3-gql (rpmlib, GLIBC filtered):
    (python3.13dist(anyio) < 5~~ with python3.13dist(anyio) >= 3)
    (python3.13dist(backoff) < 3~~ with python3.13dist(backoff) >= 1.11.1)
    (python3.13dist(graphql-core) < 3.3~~ with python3.13dist(graphql-core) >= 3.2)
    (python3.13dist(yarl) < 2~~ with python3.13dist(yarl) >= 1.6)
    /usr/bin/python3
    python(abi)



Provides
--------
python3-gql:
    python-gql
    python3-gql
    python3.13-gql
    python3.13dist(gql)
    python3dist(gql)



Diff spec file in url and in SRPM
---------------------------------
--- /home/build/dev/fedora_packaging/python-gql.spec	2025-01-09 17:58:52.000000000 +0000
+++ /home/build/dev/fedora_packaging/review-python-gql/srpm-unpacked/python-gql.spec	2024-09-29 00:00:00.000000000 +0000
@@ -21,14 +21,7 @@
 GQL architecture is inspired by React-Relay and Apollo-Client.
 
-%pyproject_extras_subpkg -n python3-gql aiohttp websockets requests httpx botocore
-
 %package -n     python3-%{pypi_name}
 Summary:        GraphQL client for Python
 
-# Explicit requires for /usr/bin/gql-cli
-# Surely there is a macro to do something like?
-# Recommends:    python3dist(gql[aiohttp]) = 3.8
-Recommends:     python3-gql+aiohttp = %{version}-%{release}
-
 %description -n python3-%{pypi_name}
 This is a GraphQL client for Python 3.7+. Plays nicely with graphene,


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -n python-gql
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Haskell, Perl, R, Ocaml, Java, fonts, C/C++, PHP, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
```

Spec URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql-3.5.0-1.fc42.src.rpm

This addresses the aiohttp dependency for gql-cli. The aiohttp dependencies are no longer a sub package and are bundled into
the main package as an install_requires - https://github.com/graphql-python/gql/pull/527

As for the timestamp preservation of cli.py, client.py, ... is there some trick to this? 

I can't see any option to pip3 install or something for setup.py to influence this. Or do I just set the timestamp myself with 

/usr/bin/touch -r gql/cli.py %{buildroot}%{python3_sitelib}/gql/cli.py
/usr/bin/touch -r gql/client.py %{buildroot}%{python3_sitelib}/gql/client.py

but that seems a bit rubbish.

Created attachment 2074525 [details]
The .spec file difference from Copr build 8494936 to 8588337

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8588337
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315554-python-gql/fedora-rawhide-x86_64/08588337-python-gql/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Waiting for https://github.com/graphql-python/gql/pull/527 probably makes sense.

Spec URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql-3.5.0-1.fc42.src.rpm

Now includes an upstream patch so running CLI without a backend installed produces informational message
rather than a crash. Package Suggests for the backends are in place.

The question about timestamps still stands:

* There's some magic to this to help `%pyproject_install` do the desired thing?
* Fix timestamps with `touch -r`.

Created attachment 2074641 [details]
The .spec file difference from Copr build 8588337 to 8590340

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8590340
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315554-python-gql/fedora-rawhide-x86_64/08590340-python-gql/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hello Steve, Sorry for the delay. Thanks for the patch! Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 167 files have unknown license. Detailed output of
     licensecheck in /home/build/dev/fedora_packaging/2315554-python-
     gql/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13,
     /usr/lib/python3.13/site-packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4342 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-gql-3.5.0-1.fc43.noarch.rpm
          python-gql-3.5.0-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp3sllt038')]
checks: 32, packages: 2

python-gql.src: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python-gql.src: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 13 filtered, 4 badness; has taken 2.1 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-gql.noarch: E: spelling-error ('graphene', '%description -l en_US graphene -> geographer')
python3-gql.noarch: E: spelling-error ('graphql', '%description -l en_US graphql -> graph')
python3-gql.noarch: W: no-manual-page-for-binary gql-cli
 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 8 filtered, 2 badness; has taken 1.0 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/gql/gql-3.5.0.tar.gz :
  CHECKSUM(SHA256) this package     : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9
  CHECKSUM(SHA256) upstream package : ccb9c5db543682b28f577069950488218ed65d4ac70bb03b6929aaadaf636de9


Requires
--------
python3-gql (rpmlib, GLIBC filtered):
    (python3.13dist(anyio) < 5~~ with python3.13dist(anyio) >= 3)
    (python3.13dist(backoff) < 3~~ with python3.13dist(backoff) >= 1.11.1)
    (python3.13dist(graphql-core) < 3.3~~ with python3.13dist(graphql-core) >= 3.2)
    (python3.13dist(yarl) < 2~~ with python3.13dist(yarl) >= 1.6)
    /usr/bin/python3
    python(abi)



Provides
--------
python3-gql:
    python-gql
    python3-gql
    python3.13-gql
    python3.13dist(gql)
    python3dist(gql)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/sbin/fedora-review -b 2315554
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: R, Java, C/C++, Ocaml, fonts, PHP, Perl, SugarActivity, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-gql

FEDORA-2025-b719c708fd (python-gql-3.5.0-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b719c708fd

FEDORA-2025-b719c708fd (python-gql-3.5.0-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-95e18245b5 (python-gql-3.5.0-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-95e18245b5

FEDORA-2025-95e18245b5 (python-gql-3.5.0-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Hi Hirotaka,

Thanks for the review.