Bug 2315607
| Summary: | Review Request: python-geopmpy - Python bindings for libgeopm | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ali Erdinc Koroglu <aekoroglu> |
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | aekoroglu, ali.erdinc.koroglu, christopher.m.cantalupo, negativo17, package-review |
| Target Milestone: | --- | Flags: | negativo17:
fedora-review+
aekoroglu: needinfo- |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://geopm.github.io | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-03-27 05:12:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2315604, 2315605, 2315606 | ||
| Bug Blocks: | |||
|
Description
Ali Erdinc Koroglu
2024-09-30 06:42:49 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091492 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315607-python-geopmpy/fedora-rawhide-x86_64/08091492-python-geopmpy/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Mixed use of spaces and tabs, starting line 12-13. 'Name:' is misaligned with the rest of the spec file, optional. Can you please build the package with the automatic build and runtime requirements? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_and_requirements It's very easy to do, for example: https://github.com/negativo17/python-sabctools/blob/master/python-sabctools.spec @ali.erdinc.koroglu can we proceed with the review? It has been a month. Thanks. Hello Simone, there are some incompatibilities when using python-macros with the upstream code. If it’s okay with you, we can complete the packaging using the old method for now. I’ll work on fixing the upstream issues and updating the spec file as soon as possible. @ali.erdinc.koroglu sorry for the delay, I'm swamped at work. Can you please reupload the SPEC file with the stuff in https://bugzilla.redhat.com/show_bug.cgi?id=2315607#c2 addressed (minus the macros as per your last comment)? Thanks. Yes sure, thank you SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/geopm/fedora-rawhide-x86_64/08632201-python-geopmpy/python-geopmpy.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/geopm/fedora-rawhide-x86_64/08632201-python-geopmpy/python-geopmpy-3.1.0-1.fc43.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8632228 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315607-python-geopmpy/fedora-rawhide-x86_64/08632228-python-geopmpy/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi @aekoroglu.com, package is approved. Sorry for the delay, I forgot completely about this review. Thanks. The Pagure repository was created at https://src.fedoraproject.org/rpms/python-geopmpy |