Bug 2317121

Summary: Review Request: rust-hidpipe - Pass hid devices to micro vms
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/hidpipe
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-08 06:20:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 8116094 to 8116136 none

Description Davide Cavalca 2024-10-07 23:41:17 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-hidpipe/rust-hidpipe.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hidpipe/rust-hidpipe-0.1.1-1.fc42.src.rpm

Description:
Pass hid devices to micro vms.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-10-07 23:42:04 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump udev to 0.9: https://github.com/AsahiLinux/hidpipe/pull/6",
]

This also needs updated input-linux, input-linux-sys and udev crates, which I'm working on in parallel.

Comment 2 Fedora Review Service 2024-10-07 23:43:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8116094
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317121-rust-hidpipe/fedora-rawhide-x86_64/08116094-rust-hidpipe/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-10-08 00:03:36 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-hidpipe/rust-hidpipe.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hidpipe/rust-hidpipe-0.1.1-1.fc42.src.rpm

Changelog:
- install systemd user units
- drop unneeded library

Comment 4 Davide Cavalca 2024-10-08 00:03:48 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump udev to 0.9: https://github.com/AsahiLinux/hidpipe/pull/6",
]
cargo-install-lib = false
extra-files = [
  "%{_userunitdir}/hidpipe.service",
  "%{_userunitdir}/hidpipe.socket",
]

[requires]
build = [
  "systemd-rpm-macros",
]

[scripts]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_userunitdir} etc/systemd/user/hidpipe.{service,socket}",
]

Comment 5 Fedora Review Service 2024-10-08 00:06:08 UTC
Created attachment 2050928 [details]
The .spec file difference from Copr build 8116094 to 8116136

Comment 6 Fedora Review Service 2024-10-08 00:06:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8116136
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317121-rust-hidpipe/fedora-rawhide-x86_64/08116136-rust-hidpipe/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2024-10-08 04:06:40 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-10-08 04:13:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hidpipe

Comment 9 Fedora Update System 2024-10-08 05:47:14 UTC
FEDORA-2024-70bfaf2bc9 (rust-hidpipe-0.1.1-2.fc41, rust-input-linux0.6-0.6.0-1.fc41, and 5 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-70bfaf2bc9

Comment 10 Fedora Update System 2024-10-08 05:48:00 UTC
FEDORA-2024-3195b2c6e2 (rust-hidpipe-0.1.1-2.fc40, rust-input-linux0.6-0.6.0-1.fc40, and 5 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3195b2c6e2

Comment 11 Fedora Update System 2024-10-08 06:18:54 UTC
FEDORA-2024-3831d2c5ea (rust-hidpipe-0.1.1-2.fc42, rust-input-linux0.6-0.6.0-1.fc42, and 5 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3831d2c5ea

Comment 12 Fedora Update System 2024-10-08 06:20:53 UTC
FEDORA-2024-3831d2c5ea (rust-hidpipe-0.1.1-2.fc42, rust-input-linux0.6-0.6.0-1.fc42, and 5 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-10-09 00:16:58 UTC
FEDORA-2024-70bfaf2bc9 (rust-hidpipe-0.1.1-3.fc41, rust-input-linux0.6-0.6.0-1.fc41, and 5 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-10-09 01:30:34 UTC
FEDORA-2024-3195b2c6e2 (rust-hidpipe-0.1.1-3.fc40, rust-input-linux0.6-0.6.0-1.fc40, and 5 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.