Bug 231754 (perl-Class-Factory)
| Summary: | Review Request: perl-Class-Factory - Base class for dynamic factory classes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | andreas |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Class-Factory/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-19 15:25:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 231758 | ||
|
Description
Chris Weyl
2007-03-11 07:36:43 UTC
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 26f71de57a277e53922f637dc0854bb1 Class-Factory-1.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/factory....ok All tests successful. Files=1, Tests=33, 0 wallclock secs ( 0.04 cusr + 0.01 csys = 0.05 CPU) APPROVED. For F7 rpm you should add in SPEC %if "%fedora" >= "7" BuildRequires: perl-devel %endif (In reply to comment #2) > For F7 rpm you should add in SPEC > %if "%fedora" >= "7" > BuildRequires: perl-devel > %endif This isn't cooked yet. The correct and portable wrt to this package would be to list all perl(...) modules as BR. In most cases this will be BuildRequires: perl(ExtUtils::MakeMaker) Okey. So I think Reporter Can either import package as it is now or wait for final conclusion on perl-devel issue and then import it. (In reply to comment #3) > This isn't cooked yet. > > The correct and portable wrt to this package would be to list all > perl(...) modules as BR. > > In most cases this will be > BuildRequires: perl(ExtUtils::MakeMaker) FWIW, this is the approach I intend to make if the split isn't rolled back. New Package CVS Request ======================= Package Name: perl-Class-Factory Short Description: Base class for dynamic factory classes Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list *** Bug 232611 has been marked as a duplicate of this bug. *** Branched, imported and building... Thanks for the review! :) |