Bug 2317856

Summary: Review Request: rust-typeid - Const TypeId and non-'static TypeId
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Cristian Le <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/typeid
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-10 18:38:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ben Beasley 2024-10-10 15:50:10 UTC
Spec URL: https://music.fedorapeople.org/rust-typeid.spec
SRPM URL: https://music.fedorapeople.org/rust-typeid-1.0.2-1.fc40.src.rpm
Description: Const TypeId and non-'static TypeId.
Fedora Account System Username: music

This is a new dependency for rust-serde-untagged 0.1.6.

Comment 1 Fedora Review Service 2024-10-10 15:55:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8126581
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317856-rust-typeid/fedora-rawhide-x86_64/08126581-rust-typeid/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cristian Le 2024-10-10 15:59:09 UTC
Straightforward single file package this one :)

(Using Fabio's template of course)

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2024-10-10 18:14:45 UTC
Thank you for the review!

https://release-monitoring.org/project/374843/

Comment 4 Fedora Admin user for bugzilla script actions 2024-10-10 18:15:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-typeid

Comment 5 Fedora Update System 2024-10-10 18:34:27 UTC
FEDORA-2024-e887fb4800 (rust-typeid-1.0.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e887fb4800

Comment 6 Fedora Update System 2024-10-10 18:38:50 UTC
FEDORA-2024-e887fb4800 (rust-typeid-1.0.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.