Bug 231814
Summary: | Review Request: avarice - Program for interfacing the Atmel JTAG ICE to GDB | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Trond Danielsen <trond.danielsen> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | hdegoede |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-10-09 20:45:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Trond Danielsen
2007-03-12 10:15:31 UTC
I have absolutely no idea what an Atmel JTAG ICE is, so there's no chance that I could test in any way, but I figure I can at least look over the packaging. You might consider using http://avarice.sourceforge.net/ for the URL as it's a bit more descriptive than the sourceforge project page, but it's also a bit out of date (saying that 2.3 is the current version). Your %description is missing a period. Those are terribly minor, though; I see nothing which would block this package. Review: * source files match upstream: c916cc130755c38cebf2d09b84fce6530e78c8bf28acab87afedbc77ac464a5a avarice-2.6.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (outside of the missing period) * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: avarice = 2.6-1.fc8 = /bin/sh /usr/bin/perl libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) * %check is not present; no test suite upstream and I haven't the hardware to test this manually. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED Thanks for the review! I am very busy this week, but will finish the package during the weekend. New Package CVS Request ======================= Package Name: avarice Short Description: Program for interfacing the Atmel JTAG ICE to GDB to allow users to debug their embedded AVR target. Owners: trond.danielsen Branches: FC-6,FC-7 InitialCC: Woops looks like you forgot to set the cvs flag, setting. http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Please follow the updated request template, where we need your FAS name instead of e-mail. New Package CVS Request ======================= Package Name: avarice Short Description: Program for interfacing the Atmel JTAG ICE to GDB to allow users to debug their embedded AVR target. Owners: trondd Branches: FC6, F-7, EL-5 InitialCC: Commits by cvsextras: yes cvs done. Is anything going to happen with this package? As far as I can tell, neither it nor uisp have ever even been built. Please give me an update; otherwise I'll go ahead and have this package removed from the CVS repository and package database. I am truly sorry for the delay. Things have just been to busy lately, so these two fell to the back of my run-queue. But I imported and built both packages yesterday, so they should be on their way to the repos asap. |