Bug 2318411

I think the requirements are as follow:

* Buildtime:
inc::Module::Install
lib
Moose::Role
namespace::autoclean
strict
warnings

* Runtime: none

* Testtime:
Catalyst
Catalyst::Controller::ActionRole
Catalyst::Runtime
Catalyst::Test
FindBin
HTTP::Request::Common
parent
Test::More

I'm unsure about the dependencies induced by the removed inc/ directory.
I've trimmed that to only Install.pm and Install/Makefile.pm, the others are probably irrelevant.

Cwd
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install.pm:22
ExtUtils::MakeMaker
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install/Makefile.pm:5
Fcntl
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install/Makefile.pm:7
File::Find
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install.pm:23
        RUNTIME Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install/Makefile.pm:194
File::Path
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install.pm:24
vars
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install.pm:26
        COMPILE Catalyst-ActionRole-RequireSSL-1.00/inc/Module/Install/Makefile.pm:9

Could you please double check ?

(In reply to Xavier Bachelot from comment #1)
>
> * Buildtime:
> inc::Module::Install
> lib
> Moose::Role

Just so we're on the same page, I'm trying to separate build requirements (i.e. required to make the module build), runtime requirements (that the module needs to run) and test requirements. I'm not sure how you can argue Moose::Role is in the first category rather than the second here.

> Could you please double check ?

New Spec URL: https://eseyman.fedorapeople.org/perl-Catalyst-ActionRole-RequireSSL/perl-Catalyst-ActionRole-RequireSSL.spec
New SRPM URL: https://eseyman.fedorapeople.org/perl-Catalyst-ActionRole-RequireSSL/perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc40.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8160307
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318411-perl-catalyst-actionrole-requiressl/fedora-rawhide-x86_64/08160307-perl-Catalyst-ActionRole-RequireSSL/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'GPL+ or Artistic'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

New Spec URL: https://eseyman.fedorapeople.org/perl-Catalyst-ActionRole-RequireSSL/perl-Catalyst-ActionRole-RequireSSL.spec
New SRPM URL: https://eseyman.fedorapeople.org/perl-Catalyst-ActionRole-RequireSSL/perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc40.src.rpm

Created attachment 2052932 [details]
The .spec file difference from Copr build 8160307 to 8160341

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8160341
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318411-perl-catalyst-actionrole-requiressl/fedora-rawhide-x86_64/08160341-perl-Catalyst-ActionRole-RequireSSL/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version 1
     and/or The Perl 5 License", "*No copyright* The Perl 5 License", "The
     Perl 5 License". 13 files have unknown license. Detailed output of
     licensecheck in /tmp/2318411-perl-Catalyst-ActionRole-
     RequireSSL/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/perl5/vendor_perl/Catalyst(perl-Catalyst-ActionRole-ACL,
     perl-Catalyst-View-PDF-Reuse, perl-Catalyst-Plugin-Static-Simple,
     perl-Catalyst-View-Mason, perl-Catalyst-Runtime, perl-Catalyst-Plugin-
     Cache, perl-Catalyst-Model-XMLRPC, perl-Catalyst-Helper-FastCGI-
     ExternalServer, perl-Catalyst-Action-REST, perl-Catalyst-Model-
     Adaptor, perl-Catalyst-Plugin-Session-Store-Delegate, perl-Catalyst-
     Controller-FormBuilder, perl-Catalyst-View-HTML-Template, perl-
     Catalyst-Plugin-ConfigLoader, perl-Catalyst-Plugin-I18N, perl-
     Catalyst-Devel, perl-Catalyst-Authentication-Credential-HTTP, perl-
     Catalyst-Action-RenderView, perl-Catalyst-Controller-HTML-FormFu,
     perl-Catalyst-Plugin-Session-State-URI, perl-Catalyst-Plugin-Session-
     State-Cookie, perl-Catalyst-Plugin-PageCache, perl-Catalyst-View-
     Component-SubInclude, perl-Catalyst-Plugin-Authorization-Roles, perl-
     Catalyst-Plugin-Setenv, perl-Catalyst-View-TT, perl-Catalyst-Plugin-
     Authorization-ACL, perl-Catalyst-Engine-Apache, perl-CatalystX-
     SimpleLogin, perl-Catalyst-Manual, perl-Catalyst-Plugin-Session-Store-
     Cache, perl-Catalyst-Component-InstancePerContext, perl-Catalyst-
     Plugin-Session-Store-File, perl-Catalyst-Plugin-CGI-Untaint, perl-
     Catalyst-Plugin-Session-Store-DBIC, perl-Catalyst-Model-DBIC-Schema,
     perl-Catalyst-Controller-ActionRole, perl-Catalyst-Plugin-StackTrace,
     perl-Catalyst-Plugin-Session, perl-Catalyst-Plugin-Email, perl-
     Catalyst-Plugin-Session-Store-FastMmap, perl-Catalyst-Authentication-
     Store-DBIx-Class, perl-Catalyst-Plugin-Authentication, perl-Catalyst-
     Plugin-Unicode, perl-Catalyst-View-Email, perl-Catalyst-Plugin-
     SubRequest), /usr/share/perl5/vendor_perl/Catalyst/ActionRole(perl-
     Catalyst-Runtime, perl-Catalyst-ActionRole-ACL, perl-CatalystX-
     SimpleLogin)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 956 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc42.noarch.rpm
          perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp9uauh5hz')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.2 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s 



Source checksums
----------------
https://cpan.metacpan.org/authors/id/E/EL/ELLIOTT/Catalyst-ActionRole-RequireSSL-1.00.tar.gz :
  CHECKSUM(SHA256) this package     : 6db1de9b010dceff5f56e2e35c779a7bcdd2173d5e350261e681e820350dda5b
  CHECKSUM(SHA256) upstream package : 6db1de9b010dceff5f56e2e35c779a7bcdd2173d5e350261e681e820350dda5b


Requires
--------
perl-Catalyst-ActionRole-RequireSSL (rpmlib, GLIBC filtered):
    perl(Moose::Role)
    perl(namespace::autoclean)
    perl-libs



Provides
--------
perl-Catalyst-ActionRole-RequireSSL:
    perl(Catalyst::ActionRole::NoSSL)
    perl(Catalyst::ActionRole::RequireSSL)
    perl(Catalyst::ActionRole::RequireSSL::Role)
    perl-Catalyst-ActionRole-RequireSSL



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2318411
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Perl, Generic
Disabled plugins: fonts, Java, Haskell, Ocaml, PHP, Python, SugarActivity, C/C++, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

I believe the bug referenced in the changelog should 2318411 rather than 2307374.
Other than that, LGTM.

The package is APPROVED.

oh, one more nitpick, %description should end with a dot, and could possibly be expanded to be more meaningful.

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Catalyst-ActionRole-RequireSSL

FEDORA-2024-a007024b29 (perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a007024b29

FEDORA-2024-a007024b29 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a007024b29 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a007024b29

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

(In reply to Xavier Bachelot from comment #8)
>
> I believe the bug referenced in the changelog should 2318411 rather than 2307374.

Indeed.

(In reply to Xavier Bachelot from comment #9)
>
> oh, one more nitpick, %description should end with a dot, and could possibly
> be expanded to be more meaningful.

Indeed.

I changed both the changelog and the description in my .spec but, because I imported the .src.rpm, this was ignored. Fixed but only in Rawhide.

> The package is APPROVED.

Thank you for the review, Xavier.

FEDORA-2024-a007024b29 (perl-Catalyst-ActionRole-RequireSSL-1.00-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.