Bug 2318468

Taking this review.

Initial spec review:

> %define debug_package %{nil}

What's this for? This is an archful package, so it should be able to generate debuginfo properly.

> ./configure.sh --prefix=/usr

This should be set to "--prefix=%{_prefix}" instead.

There's also weirdness with how this package is built, and I think our build flags aren't making it into the package, particularly with the Rust part.

@Fabio, do you have any idea how to make this work right?

- Version 1.1.2 doesn't contain Rust code yet.
- The Rust code was added later.
- 1.1.4 is the latest version.
- The native module written in Rust was added *after* that.

> %define debug_package %{nil}

So, yes, this should probably be replaced with "BuildArch: noarch" for now.

Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1.fc42.src.rpm

Updated to 1.1.4, Removed debug packages global var, Set buildarch to noarch

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8551634
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318468-umu-launcher/fedora-rawhide-x86_64/08551634-umu-launcher/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I took another look, I hope Neal doesn't mind :)

It looks like making this "noarch" doesn't quite work, likely due to a bug in the upstream Makefiles:

There's a file getting installed to /usr/lib64/python3.13/site-packages/umu (umu_version.json).

> %{python3_sitelib}/umu/
> %{python3_sitearch}/umu/

This looks like a mistake, that umu_version.json file should probably be in python3_sitelib, not in python3_sitearch.

> %{_mandir}/man1/umu.1.gz
> %{_mandir}/man5/umu.5.gz

Don't list .gz explicitly, use .*

> %{_datadir}/steam/compatibilitytools.d/umu-launcher/

Either this package needs to (co?)-own steam/ and steam/compatibilitytools.d/ folders too, or it needs to "Require" the package that contains these.
Probably the former, since steam isn't in the main Fedora repos.

I'm also a bit confused by the BuildRequires that you've listed:

> BuildRequires:  python3-devel
> BuildRequires:  meson >= 0.54.0
> BuildRequires:  ninja-build
> BuildRequires:  cmake
> BuildRequires:  gcc-c++
> BuildRequires:  scdoc

The package contains neither meson.build (meson / ninja), nor CMakeLists.txt (cmake), nor any C++ source files (*.cpp).

Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1.fc42.src.rpm

Cleaned the BRs, removed package's noarch, cleaned up %files a bit

> removed package's noarch

Why? The package is clearly noarch, the fact that it installs something to %python3_sitearch looks like a bug in the upstream Makefile.

Created attachment 2073739 [details]
The .spec file difference from Copr build 8551634 to 8568357

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8568357
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318468-umu-launcher/fedora-rawhide-x86_64/08568357-umu-launcher/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1.fc42.src.rpm

Put the package back to noarch, waiting for an upstream fix to fix the dangling json file

Created attachment 2073740 [details]
The .spec file difference from Copr build 8568357 to 8568381

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8568381
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318468-umu-launcher/fedora-rawhide-x86_64/08568381-umu-launcher/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

What's delaying this? it seems the problem it's not known by upstream? (https://github.com/Open-Wine-Components/umu-launcher/issues/437)

I tried to update to the latest version. It looks like the rust parts need work, as that package's script tries to download the rust crates, which Fedora doesn't allow. and it seems it doesn't accept bundled crates.

If someone wants to take this over, then go for it.