Bug 2318791

Summary:	Review Request: rust-libmonado - Rust bindings to the libmonado library that controls Monado from other processes
Product:	[Fedora] Fedora	Reporter:	Jonathan Steffan <jonathansteffan>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-17 15:07:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2292541

Description Jonathan Steffan 2024-10-15 15:15:59 UTC

Spec URL: https://jsteffan.fedorapeople.org/envision/rust-libmonado.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-libmonado-1.3.1-1.fc40/rust-libmonado-1.3.1-1.fc42.src.rpm
Description: Rust bindings to the libmonado library that controls Monado from other processes
Fedora Account System Username: jsteffan

Comment 1 Fabio Valentini 2024-10-17 10:13:48 UTC

Looks good to me! You don't need to copy the error messages into the spec file, "this requires a running instance of service X" is enough of a justification.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (disabled with justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Fedora Admin user for bugzilla script actions 2024-10-17 14:52:13 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libmonado

Comment 3 Fedora Update System 2024-10-17 15:04:06 UTC

FEDORA-2024-eb987e5159 (rust-libmonado-1.3.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-eb987e5159

Comment 4 Fedora Update System 2024-10-17 15:07:06 UTC

FEDORA-2024-eb987e5159 (rust-libmonado-1.3.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.