Bug 2319081

Summary: xdg-user-dirs races with plasma startup and doesn't complete fast enough sometimes in openqa and kinoite
Product: [Fedora] Fedora Reporter: Lukas Ruzicka <lruzicka>
Component: xdg-user-dirsAssignee: Matthias Clasen <mclasen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 41CC: alexl, awilliam, gnome-sig, hygorhernane, jgrulich, kde-sig, mclasen, nate, ngompa13, rdieter, than, vinicius.fedora
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: openqa AcceptedFreezeException
Fixed In Version: xdg-user-dirs-0.18-7.fc40 xdg-user-dirs-0.18-7.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-15 02:23:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2247868    
Attachments:
Description Flags
Firefox icon present on 20241013 nightly compose.
none
Firefox icon absent on 20241015 nightly compose.
none
Screenshot of Kickoff with Firefox from the Oct 15 test image none

Description Lukas Ruzicka 2024-10-16 07:49:35 UTC
Recently, there was a Firefox icon in the Favorites menu and we utilized it to start Firefox in our openQA tests. see attachment. In the latest compose from the 15th of October, however, the Firefox icon is gone.

Reproducible: Always

Steps to Reproduce:
1. Install 20241015 KDE.
2. Open the Favorites menu.
Actual Results:  
No Firefox icon present.

Expected Results:  
Firefox icon is there as it used to be.

Comment 1 Lukas Ruzicka 2024-10-16 07:51:51 UTC
Created attachment 2052262 [details]
Firefox icon present on 20241013 nightly compose.

See how we have utilized the Firefox launcher to start desktop browser as late as on 20241013.

Comment 2 Lukas Ruzicka 2024-10-16 07:52:52 UTC
Created attachment 2052263 [details]
Firefox icon absent on 20241015 nightly compose.

Yet, on the next compose 20241015, it is no longer there.

Comment 3 Fedora Blocker Bugs Application 2024-10-16 07:58:02 UTC
Proposed as a Freeze Exception for 41-final by Fedora user lruzicka using the blocker tracking app because:

 They took our icon away, we want it back.

Comment 4 Neal Gompa 2024-10-16 11:24:09 UTC
Oddly enough, the patch that sets the favorites is still there: https://src.fedoraproject.org/rpms/plasma-desktop/blob/rawhide/f/plasma-desktop-5.90.0-default_favorites.patch

Comment 5 Neal Gompa 2024-10-16 13:44:07 UTC
Created attachment 2052316 [details]
Screenshot of Kickoff with Firefox from the Oct 15 test image

So I just downloaded and installed the October 15 image, and I cannot reproduce the issue. The attached screenshot demonstrates it's there as expected.

Comment 6 Adam Williamson 2024-10-16 15:38:06 UTC
it seems to be an intermittent bug. sometimes it's there, sometimes it isn't. It's actually been happening for a while, but the openQA "retry once on failure" mechanism has been saving us from noticing. The earliest occurrence I can find seems to be https://openqa.fedoraproject.org/tests/2917970 , 15 days ago, but it's getting much more common recently. I suspect it's tied to the whole "KDE just seems slow and flakey in openQA lately" situation. You can get a feel for it by looking at the "Next & previous results" tab on openQA. https://openqa.fedoraproject.org/tests/2957276 is the most recent incidence of this bug. If you go to its "Next & previous results" tab and expand the view to 100 runs per page, you can really get a feel for it.

The first page has lots of failures - almost all of which are this bug, you can tell by looking at the failure thumbnail - and all the passes are actually softfails (orange) because firefox takes a long time to start up (if it takes more than 45 seconds from clicking on the launcher for Firefox's UI to be fully loaded, openQA marks it as a soft fail). The second page has fewer failures, and you can see right around 2024-10-04 is where the oranges kick in, before that it's nearly all greens. Page 3 has a cluster of failures from a network outage, but otherwise is nearly all green. Page 4 (as I write this) is all green.

You can see the exact same pattern on staging (start at https://openqa.stg.fedoraproject.org/tests/4342044 there), so this doesn't look like it's openQA that's gone weird, it really seems like KDE has been degrading lately.

Comment 7 Adam Williamson 2024-10-16 15:42:39 UTC
oh, and if you check next/previous for the GNOME test - start at https://openqa.fedoraproject.org/tests/2957292 - it's a symphony of green, so this is definitely KDE-specific.

Comment 8 Adam Williamson 2024-10-16 15:44:47 UTC
The onset of these issues looks like it matches quite neatly with when the 6.2.0 final megaupdate landed: Fri Oct  4 08:51:10 2024 kwin-6.2.0-1.fc42 tagged into f42 by bodhi . so possibly this was introduced by something between 6.1.90 and 6.2.0.

Comment 9 Adam Williamson 2024-10-16 15:46:40 UTC
The same story holds with other tests, e.g. desktop_printing - start at https://openqa.fedoraproject.org/tests/2957266 . The next/previous view has a *ton* of red back to a failure on FEDORA-2024-0a1e0076d2 at 10:29 on 2024-10-04; before that, it's almost all green.

Comment 10 Adam Williamson 2024-10-16 17:15:55 UTC
Oh hey. So this is probably just because https://bugzilla.redhat.com/show_bug.cgi?id=2312900 came back. I'm fixing that now.

*** This bug has been marked as a duplicate of bug 2312900 ***

Comment 11 Adam Williamson 2024-10-17 16:45:19 UTC
Hum. In https://openqa.stg.fedoraproject.org/tests/4347778#step/desktop_browser/27 , this happened on kwin-6.2.1.1-1.fc42 , which seems concerning :(

Comment 12 Adam Williamson 2024-10-17 16:48:31 UTC
It's not a *ton* of data, but since openQA started picking up the fix for the performance issue yesterday, results for desktop_printing (which doesn't go through Favorites) are 100% green on prod and stg, but results for desktop_browser (which does go through Favorites) have three fails on stg and one on prod. So it kinda looks like this was indeed broken by the 6.2.0 update, but it's *not* just a symptom of the performance issue.

Comment 13 Adam Williamson 2024-10-21 15:57:35 UTC
+4 in https://pagure.io/fedora-qa/blocker-review/issue/1704 , marking accepted FE.

Comment 14 Adam Williamson 2024-11-06 17:55:05 UTC
Just to confirm, this definitely has kept happening and was not part of the performance bug and is still happening. It's still causing tests to fail periodically, which is a PITA :|

Comment 15 Adam Williamson 2025-02-12 23:24:49 UTC
This is still happening, and still a PITA.

Comment 16 Neal Gompa 2025-02-13 02:10:55 UTC
This should help fix it, since it resolves the race that occurs when this runs for first login: https://src.fedoraproject.org/rpms/xdg-user-dirs/pull-request/4

Comment 17 Fedora Update System 2025-02-13 16:23:37 UTC
FEDORA-2025-6905d9518a (xdg-user-dirs-0.18-7.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6905d9518a

Comment 18 Fedora Update System 2025-02-13 16:23:42 UTC
FEDORA-2025-ac891d77a9 (xdg-user-dirs-0.18-7.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ac891d77a9

Comment 19 Fedora Update System 2025-02-14 01:33:05 UTC
FEDORA-2025-6905d9518a has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6905d9518a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6905d9518a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2025-02-14 02:36:33 UTC
FEDORA-2025-ac891d77a9 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ac891d77a9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ac891d77a9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2025-02-15 02:23:13 UTC
FEDORA-2025-6905d9518a (xdg-user-dirs-0.18-7.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2025-02-15 02:36:39 UTC
FEDORA-2025-ac891d77a9 (xdg-user-dirs-0.18-7.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.