Bug 2319247

Summary: Review Request: rust-isal-rs - Isa-l Rust bindings
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/isal-rs
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-08 13:25:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2319246    
Bug Blocks: 2277635    
Attachments:
Description Flags
Configuration file for rust2rpm none

Description Ben Beasley 2024-10-16 19:11:12 UTC
Created attachment 2052364 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-isal-rs.spec
SRPM URL: https://music.fedorapeople.org/rust-isal-rs-0.5.3-1.fc40.src.rpm
Description: Isa-l Rust bindings.
Fedora Account System Username: music

Comment 1 Fedora Review Service 2024-10-16 19:11:24 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2024-10-16 19:11:26 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2024-10-17 18:39:57 UTC
COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/libcramjam/build/8143387/

Comment 4 Ben Beasley 2024-10-17 18:40:27 UTC
I need to add this on import:

  # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
  # Additionally, the isa-l package is ExcludeArch: %%{ix86}.
  ExcludeArch:    %{ix86}

Comment 5 Ben Beasley 2024-10-19 13:12:23 UTC
(In reply to Ben Beasley from comment #4)
> I need to add this on import:
> 
>   # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
>   # Additionally, the isa-l package is ExcludeArch: %%{ix86}.
>   ExcludeArch:    %{ix86}

I went ahead and added this and uploaded a new submission.

New Spec URL: https://music.fedorapeople.org/20241019/rust-isal-rs.spec
New SRPM URL: https://music.fedorapeople.org/20241019/rust-isal-rs-0.5.3-1.fc40.src.rpm

Koji scratch build in Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=124981600

Comment 6 Fedora Review Service 2024-10-19 13:14:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8158117
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2319247-rust-isal-rs/fedora-rawhide-x86_64/08158117-rust-isal-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Ben Beasley 2024-10-19 13:27:19 UTC
(In reply to Fedora Review Service from comment #6)
> Please make sure the package builds successfully at least for Fedora Rawhide.

(The rust-isal-sys dependency is in the Rawhide buildroot, but apparently has not yet been included in a compose.)

Comment 8 Fabio Valentini 2024-12-07 18:09:10 UTC
Package was generated with rust2rpm, simplifying the review.

You might want to regenerate with rust2rpm v27 before importing.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 9 Ben Beasley 2024-12-08 12:43:08 UTC
Thank you for the review! I’m looking forward to getting the cramjam packages up to date.

https://release-monitoring.org/project/375028/

Comment 10 Fedora Admin user for bugzilla script actions 2024-12-08 12:43:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-isal-rs

Comment 11 Fedora Update System 2024-12-08 13:20:24 UTC
FEDORA-2024-51ef43d569 (rust-isal-rs-0.5.3-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-51ef43d569

Comment 12 Fedora Update System 2024-12-08 13:25:25 UTC
FEDORA-2024-51ef43d569 (rust-isal-rs-0.5.3-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-12-08 15:11:02 UTC
FEDORA-2024-a8a3e0780a (rust-isal-rs-0.5.3-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

Comment 14 Fedora Update System 2024-12-08 16:00:19 UTC
FEDORA-2024-6b4790a9f9 (rust-isal-rs-0.5.3-2.fc40 and rust-isal-sys-0.5.3-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b4790a9f9

Comment 15 Fedora Update System 2024-12-09 01:16:32 UTC
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a8a3e0780a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-12-09 03:14:09 UTC
FEDORA-2024-6b4790a9f9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6b4790a9f9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b4790a9f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-12-11 01:42:14 UTC
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-12-13 02:46:11 UTC
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2024-12-14 03:10:49 UTC
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2024-12-17 04:04:38 UTC
FEDORA-2024-6b4790a9f9 (rust-isal-rs-0.5.3-2.fc40 and rust-isal-sys-0.5.3-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-12-22 02:01:12 UTC
FEDORA-2024-a8a3e0780a (cramjam-cli-0.1.1-9.fc41, python-cramjam-2.9.1-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.