Bug 2319670

Summary:	python-jinja2-time fails to build with setuptools 74+
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-jinja2-time	Assignee:	fedepell <fede>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	chedi.toueiti, fede
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-jinja2-time-0.2.0-27.fc42	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-22 10:59:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2319387

Description Miro Hrončok 2024-10-18 10:11:04 UTC

Dear package maintainer,

this bugzilla is automated becasue the number of impacted packages it too high to go trough manually.

It appears that your package failed to build with setuptools 74.1.3 and wheel 0.44 in

  https://copr.fedorainfracloud.org/coprs/churchyard/setuptools-74/package/python-jinja2-time/

While it succeeded with setuptools 69.2.0 and wheel 0.43 in

  https://copr.fedorainfracloud.org/coprs/churchyard/setuptools-control/package/python-jinja2-time/

This usually means this package fails to build with setuptools 74+

We plan to update setuptools to version 74 or newer in Fedora 42. This is an approved Fedora 42 Change:

  https://fedoraproject.org/wiki/Changes/Setuptools_74+



Please analyze the failure and fix it in rawhide. Thanks.


You can use the builds from the churchyard/setuptools-74 copr for local testing.

  mock -r fedora-rawhide-x86_64 --addrepo 'https://download.copr.fedorainfracloud.org/results/churchyard/setuptools-74/fedora-rawhide-$basearch/'


One of the most common problems is that the setup.py test command cannot be used. If that is the case here, run the tests in %check differently, e.g. via %pytest, %tox, %{python3} -m unittest, etc.


If you need help, reach out to me in this bugzilla.

Comment 1 fedepell 2024-10-21 03:24:09 UTC

Thanks for the heads up!

I've locally enabled the test calling pytest directly but then they fail. But I realize in previous versions there was no test running:

```
writing manifest file 'jinja2_time.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
```

And indeed running them manually on my current FC40 also leads to failure.

Does it sound reasonable to you if I just disable them for the time being (so would be de-facto equivalent to previous releses)?

I'm actually considering as well if it is worth fixing or orphaning the package, as I maintained it since it was a dependency for python-cookiecutter but that doesn't depend on jinja2-time anymore (they have just inlined the code here inside instead of using the separate module, I guess since it was unmaintained upstream from a long time) so now keeping this one may be not worth.

Thanks for your input!
F.

Comment 2 Miro Hrončok 2024-10-21 11:01:58 UTC

> Does it sound reasonable to you if I just disable them for the time being (so would be de-facto equivalent to previous releases)?

I suggest running at least an import check (%py3_check_import or %pyproject_check_import).



$ repoquery -q --repo=rawhide{,-source} --whatrequires python3-jinja2-time
(nothing)


I'd orphan the package if it were me.

Comment 3 fedepell 2024-10-22 07:07:31 UTC

Should be fixed now, found a MR to upstream (oversaw it Sunday) that fixes compatibility and now tests as well work and run nice. Will consider backporting to 41 soon!

Just pushed, I guess ticket should get automatically closed by Bodhi soon. Let's then push the retirement to the next blocker :)

Comment 4 Miro Hrončok 2024-10-22 10:59:10 UTC

Thanks.