Bug 2319722

Summary:	python-sql fails to build with setuptools 74+
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-sql	Assignee:	Dan Horák <dan>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dan
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-sql-1.5.2-2.fc42	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-22 11:53:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2319387

Description Miro Hrončok 2024-10-18 10:14:28 UTC

Dear package maintainer,

this bugzilla is automated becasue the number of impacted packages it too high to go trough manually.

It appears that your package failed to build with setuptools 74.1.3 and wheel 0.44 in

  https://copr.fedorainfracloud.org/coprs/churchyard/setuptools-74/package/python-sql/

While it succeeded with setuptools 69.2.0 and wheel 0.43 in

  https://copr.fedorainfracloud.org/coprs/churchyard/setuptools-control/package/python-sql/

This usually means this package fails to build with setuptools 74+

We plan to update setuptools to version 74 or newer in Fedora 42. This is an approved Fedora 42 Change:

  https://fedoraproject.org/wiki/Changes/Setuptools_74+



Please analyze the failure and fix it in rawhide. Thanks.


You can use the builds from the churchyard/setuptools-74 copr for local testing.

  mock -r fedora-rawhide-x86_64 --addrepo 'https://download.copr.fedorainfracloud.org/results/churchyard/setuptools-74/fedora-rawhide-$basearch/'


One of the most common problems is that the setup.py test command cannot be used. If that is the case here, run the tests in %check differently, e.g. via %pytest, %tox, %{python3} -m unittest, etc.


If you need help, reach out to me in this bugzilla.

Comment 1 Dan Horák 2024-10-18 16:35:10 UTC

Hi Miro,

I am having issues migrating python-sql to use the tox tool for running tests. Please see tox.ini at https://foss.heptapod.net/tryton/python-sql/-/blob/branch/default/tox.ini?ref_type=heads, it seems to require unittest-xml-reporting which we don't have in Fedora. I can patch it out. But it seems it is required for https://foss.heptapod.net/tryton/python-sql/-/blob/branch/default/tox.ini?ref_type=heads#L12 (the -m xmlrunner option). Any hint how to make it running? A scratch build for my WIP spec file is https://koji.fedoraproject.org/koji/taskinfo?taskID=124958264

Comment 2 Miro Hrončok 2024-10-21 19:32:43 UTC

I'd try circumventing tox in this case as coverage is an undesired dependency anyway https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters

Try something like:

  %check
  %{py3_test_envvars} %{python3} -m unittest discover -s sql.tests

Comment 3 Dan Horák 2024-10-22 08:04:48 UTC

Thanks a lot, Miro. If I understand it right, then tox is used purely for the coverage, thus I am removing tox.ini completely now. And with your %check command the build runs OK.

Comment 4 Fedora Update System 2024-10-22 08:13:10 UTC

FEDORA-2024-25a3efb7fc (python-sql-1.5.2-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-25a3efb7fc

Comment 5 Fedora Update System 2024-10-22 08:28:34 UTC

FEDORA-2024-25a3efb7fc (python-sql-1.5.2-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Miro Hrončok 2024-10-22 10:57:04 UTC

This is not necessary:

  rm tox.ini

Instead, drop -t from %pyproject_buildrequires -t.

Now this package BuildRequires tox for no good reason.

Comment 7 Dan Horák 2024-10-22 11:50:00 UTC

you are right, fixed :-)

Comment 8 Miro Hrončok 2024-10-22 11:53:33 UTC

Thanks!