Bug 2319750
| Summary: | tpm2-pkcs11 fails to build with setuptools 74+ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | tpm2-pkcs11 | Assignee: | Jakub Jelen <jjelen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, jjelen, pbrobinson, shoracek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-29 12:23:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2319387 | ||
|
Description
Miro Hrončok
2024-10-18 10:16:21 UTC
I plan to update setuptools to 74.x in rawhide this week. At that point, this package will fail to build from source if not fixed. If I see right, the only issue is the following: /usr/lib/python3.13/site-packages/setuptools/_distutils/dist.py:261: UserWarning: Unknown distribution option: 'tests_require' I will test it works as expected and if so, I will push an update later today. No, its the issue of running /usr/bin/python3 setup.py test but if I run it locally with old version, I see no tests run anyway, so I will just go ahead and remove that test execution: NO TESTS RAN Perhaps take it as an opportunity to actually run some tests during the build. If there are no tests upstream, consider at least running an import check. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests For the purposes of this bug, deleting the %check section will do, but it's not "nice" :) I was probably not clear enough. The `make check` runs, but the invocation from that specific directory did not run any tests. This is the transcript of the rerun I did locally with your repo: ``` $ mock -r fedora-rawhide-x86_64 --addrepo 'https://download.copr.fedorainfracloud.org/results/churchyard/setuptools-74/fedora-rawhide-x86_64' --rebuild /home/jjelen/devel/fedora/tpm2-pkcs11/tpm2-pkcs11-1.9.1-1.fc42.src.rpm [...] + make check make test/unit/test_twist test/unit/test_log test/unit/test_parser test/unit/test_attr test/unit/test_db test/unit/test_utils make[1]: Entering directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' CC test/unit/test_twist-test_twist.o CCLD test/unit/test_twist CC test/unit/test_log-test_log.o CCLD test/unit/test_log CC test/unit/test_parser-test_parser.o CCLD test/unit/test_parser CC test/unit/test_attr-test_attr.o CCLD test/unit/test_attr CC test/unit/test_db-test_db.o CCLD test/unit/test_db CC test/unit/test_utils-test_utils.o CCLD test/unit/test_utils make[1]: Leaving directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' make check-TESTS make[1]: Entering directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' make[2]: Entering directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' PASS: test/unit/test_twist PASS: test/unit/test_log PASS: test/unit/test_parser PASS: test/unit/test_attr PASS: test/unit/test_db PASS: test/unit/test_utils ============================================================================ Testsuite summary for tpm2-pkcs11 1.9.1 ============================================================================ # TOTAL: 6 # PASS: 6 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ make[2]: Leaving directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' make[1]: Leaving directory '/builddir/build/BUILD/tpm2-pkcs11-1.9.1-build/tpm2-pkcs11-1.9.1' ``` I pushed the changes in rawhide: https://src.fedoraproject.org/rpms/tpm2-pkcs11/c/a9819573e5f9f4b92141c43206df51394333fcce?branch=rawhide I assume we do not need a new build as I expect mass rebuild. If I am wrong, please let me know and I will rebuild. A new build is not needed unless you care about https://koschei.fedoraproject.org/package/tpm2-pkcs11 results. |