Bug 2320056

Summary: Review Request: rust-borrow-or-share - Traits for either borrowing or sharing data
Product: [Fedora] Fedora Reporter: Kai A. Hiller <fedora>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: POST --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/borrow-or-share
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kai A. Hiller 2024-10-20 18:05:42 UTC
Spec URL: https://v02460.fedorapeople.org/rust-borrow-or-share.spec
SRPM URL: https://v02460.fedorapeople.org/rust-borrow-or-share-0.2.2-1.fc42.src.rpm
Description: Traits for either borrowing or sharing data.
Fedora Account System Username: v02460

Comment 1 Fedora Review Service 2024-10-20 18:39:36 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8159979
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2320056-rust-borrow-or-share/fedora-rawhide-x86_64/08159979-rust-borrow-or-share/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-12-07 18:15:43 UTC
Package was generated with rust2rpm, simplifying the review.

You might want to regenerate the spec file with rust2rpm v27 before importing, but that's not a MUST.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2025-03-29 22:27:08 UTC
If you're still interested in this package, please let me know - I need to refresh the fedora-review + flag in that case.

Comment 4 Kai A. Hiller 2025-03-31 23:29:11 UTC
Hey Fabio, thank you for the follow-up! I’m still interested in this package and would be happy if you renewed the approval :)

Comment 5 Fabio Valentini 2025-04-01 10:08:41 UTC
done!