Bug 232036 (perl-YAML-Tiny)
| Summary: | Review Request: perl-YAML-Tiny - Read/Write YAML files with as little code as possible | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | panemade:
fedora-review+
petersen: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-18 23:57:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 232018 | ||
| Bug Blocks: | |||
|
Description
Steven Pritchard
2007-03-13 17:43:31 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
edba36ca379be0c5f8176239b8f547d9 YAML-Tiny-1.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test AUTOMATED_TESTING=1
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t
t/01_compile.......ok
t/02_basic.........ok
63/594 skipped: various reasons
t/03_regression....ok
t/11_meta_yml......ok
t/12_plagger.......ok
7/44 skipped: Skipping YAML::Syck compatibility testing
t/13_perl_smith....ok
7/26 skipped: Skipping YAML::Syck compatibility testing
t/14_yaml_org......ok
t/99_author........ok
All tests successful, 77 subtests skipped.
Files=8, Tests=804, 2 wallclock secs ( 1.40 cusr + 0.12 csys = 1.52 CPU)
+ Provides: perl(YAML::Tiny) = 1.04
Why make test skipped compatibility testing?
(In reply to comment #1) > Why make test skipped compatibility testing? I'm honestly not sure. Having it available in the build tree should be enough. APPROVED. New Package CVS Request ======================= Package Name: perl-YAML-Tiny Short Description: Read/Write YAML files with as little code as possible Owners: steve Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: fedora-perl-devel-list Imported, builds requested, etc. Thanks. Package Change Request ====================== Package Name: perl-YAML-Tiny New Branches: F-7 This is going to need a F-7 branch in order to avoid upgrade problems. branch added |