Bug 2320821

Proposing as an F41 Final FE in case the compose we're running now is no-go, and a fix for this shows up before we do another.

There's so little functionality in gnome-clocks, that broken alarms feel like a basic functionality violation. Proposing as a final blocker.

In my testing, the popup notification shows up (but you might not see it, e.g. if you have some fullscreen content), and the audio doesn't play. You have to kill gnome-clocks and start it again, and the alarm starts finally playing as audio.

Any objection to me shipping your patch for Fedora rawhide and 41, or wait until merged?

mclasen thinks it's wrong, so hold your horses, I guess. See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7858#note_2255201 and replies.

Equine progress restricted.

Dropping POST as mclasen says my fix isn't right.

There's an updated proposed fix now. However, Benjamin says "This is quite an invasive commit and I did minimal testing on it, just confirming that gnome-clocks works.
While this is fine to go into main because it should be the right thing, it'd probably warrant some more testing before putting it into a stable branch.", so I'm not sure we'd want to rush this into a late RC. It might make rather more sense to just ship with the known bug which we can document, and fix this with a post-release update that can have more testing.

I will do a scratch build and link it here, though.

Scratch build with the patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=125092333

+4 FE in https://pagure.io/fedora-qa/blocker-review/issue/1730 , marking accepted.

(In reply to Adam Williamson from comment #8)
> Scratch build with the patch:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=125092333

This fixes gnome-clocks for me. I'll be on watch for potential gtk issues in other apps.

Yes, I can confirm. The scratch build fixes the bug.

Discussed during the 2024-10-24 Go/No-Go blocker review meeting: [1]

The decision to classify this bug as a RejectedBlocker (Final) was made:

"Consensus could not be reached that this violates the proposed criterion "https://fedoraproject.org/wiki/QA:Testcase_desktop_app_basic" as discussed by the stakeholders. While alarm is an important function of a Clocks application, it wasn't deemed that it fits the basic functionality criterion."

[1] https://meetbot.fedoraproject.org/meeting_matrix_fedoraproject-org/2024-10-24/f41-final-go-no-go-meeting.2024-10-24-17.02.log.html

Following this through upstream, it looks like the initial fix for this - https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7859 - was merged but then reverted and replaced in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7865 . It was then backported to the 4.16 branch and landed in 4.16.4.

4.16.5 is now stable in Rawhide so this should be fixed there (the last compose still included 4.16.3, though, so can't tell until the next compose is done). It's not yet built for F41. I'm asking if we can get it built for F41 so this will be fixed.

FEDORA-2024-ef2a265dd9 (gtk4-4.16.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ef2a265dd9

FEDORA-2024-ef2a265dd9 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ef2a265dd9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ef2a265dd9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

The mentioned update fixes the issue for me. Thanks.

FEDORA-2024-ef2a265dd9 (gtk4-4.16.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.