Bug 2320878

Summary:	Review Request: rust-zips - Macros for wrapping up a bunch of Option/Result into a single Option
Product:	[Fedora] Fedora	Reporter:	solomoncyj
Component:	Package Review	Assignee:	Cristian Le <fedora>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	41	CC:	benson_muite, fedora, package-review
Target Milestone:	---	Flags:	fedora: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-05-21 00:27:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841, 2310209

Description solomoncyj 2024-10-22 08:23:53 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08162737-rust-zips/rust-zips.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08162737-rust-zips/rust-zips-0.1.7-1.fc42.src.rpm
Description: Routines for safe string operations 
Fedora Account System Username: solomoncyj

Reproducible: Always

Reproducible: Always

Comment 1 Cristian Le 2024-10-23 14:25:37 UTC

LGTM, just need someone to sponsor you.

(Using Fabio's template)

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Fedora Review Service 2024-10-23 14:26:05 UTC

Hello @solomoncyj,
since this is your first Fedora package, you need to get sponsored by a package
sponsor before it can be accepted.

A sponsor is an experienced package maintainer who will guide you through
the processes that you will follow and the tools that you will use as a future
maintainer. A sponsor will also be there to answer your questions related to
packaging.

You can find all active sponsors here:
https://docs.pagure.org/fedora-sponsors/

I created a sponsorship request for you:
https://pagure.io/packager-sponsors/issue/688
Please take a look and make sure the information is correct.

Thank you, and best of luck on your packaging journey.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 3 Benson Muite 2024-12-21 04:13:07 UTC

Congratulations on a positive review. Perhaps use the rust sig
communication channels:
https://fedoraproject.org/wiki/SIGs/Rust
to find a sponsor and get reviewers for your other packages.