Bug 2320992

Summary: Please branch and build python-mccabe in epel10
Product: [Fedora] Fedora EPEL Reporter: Romain Geissler <romain.geissler>
Component: python-mccabeAssignee: Tom.Rix
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel10CC: gwync, python-packagers-sig, Tom.Rix
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-mccabe-0.7.0-11.el10_0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-30 00:32:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2321056    
Bug Blocks: 2320838    

Description Romain Geissler 2024-10-22 14:02:37 UTC
Hi,

Please branch and build python-mccabe in epel10.

It seems to be a dependency of pylint which would be needed in epel 10 as well: https://bugzilla.redhat.com/show_bug.cgi?id=2320838

Cheers,
Romain

Comment 1 Gwyn Ciesla 2024-10-22 16:16:56 UTC
DEBUG util.py:461:  No matching package to install: 'python3-hypothesmith'

Comment 2 Romain Geissler 2024-10-22 16:31:06 UTC
hypothesmith seems to be an test dependency only: https://github.com/PyCQA/mccabe/blob/60cf21c21f8e5880f9907561c53732e80d1be400/tox.ini#L9

And looking at the source code, it's even an optional test dependency (the test is skipped if the import fails): https://github.com/PyCQA/mccabe/blob/60cf21c21f8e5880f9907561c53732e80d1be400/test_mccabe.py#L257

Comment 3 Romain Geissler 2024-10-22 16:32:21 UTC
However we could also ask for hypothesmith to be branched for EPEL 10, it seems it has never been part of EPEL in branch 8 or 9.

Comment 4 Gwyn Ciesla 2024-10-22 16:39:28 UTC
Unless hypothesmith brings in a massive set of packages, I'd rather we ask for it to be branched for EPEL 10.

Comment 5 Tom.Rix 2024-11-16 14:20:55 UTC
Building on cs10+epel fails.
Can you provide a patch to resolve this error ?

/usr/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
test_mccabe.py:244: in <module>
    @settings(
E   NameError: name 'settings' is not defined
=========================== short test summary info ============================
ERROR test_mccabe.py - NameError: name 'settings' is not defined
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.09s ===============================
error: Bad exit status from /var/tmp/rpm-tmp.MgETa6 (%check)

Comment 6 Romain Geissler 2024-11-20 04:17:20 UTC
Hi,

This happens because the python-hypothesmith dependency doesn't exist, and I guess you tried to comment it out to build the package: https://bugzilla.stage.redhat.com/show_bug.cgi?id=2261579

Running tests does require this library, so we shall wait that the maintainer of this lib creates an EPEL 10 build for it.

Cheers,
Romain

Comment 7 Tom.Rix 2024-12-25 22:37:59 UTC
Removed hypothesmith from the tests, please check here
https://koji.fedoraproject.org/koji/buildinfo?buildID=2606021

Comment 8 Romain Geissler 2024-12-25 22:46:50 UTC
Hi,

Thanks. Can you please submit this build as part of a Fedora update ? Otherwise this package will never be made available to EPEL users. The built package installs fine inside a C10S container.

Comment 9 Fedora Update System 2024-12-28 13:13:37 UTC
FEDORA-EPEL-2024-2f354a856d (python-mccabe-0.7.0-11.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2f354a856d

Comment 10 Fedora Update System 2024-12-29 02:23:17 UTC
FEDORA-EPEL-2024-2f354a856d has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2f354a856d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-12-30 00:32:01 UTC
FEDORA-EPEL-2024-2f354a856d (python-mccabe-0.7.0-11.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.