Bug 232222
| Summary: | rpm-4.4.2-debugpaths.patch broken | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jakub Jelinek <jakub> | ||||||
| Component: | rpm | Assignee: | Paul Nasrat <nobody+pnasrat> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 6 | CC: | aph | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-04-23 10:57:21 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 150040 [details]
rpm-4.4.2-debugedit-canonicalize-path.patch
It seems canonicalize_path doesn't handle ../../ right (and messes other things
as well).
Try:
int
main (void)
{
char buf[64];
canonicalize_path("/a/b/././//c/../../d/e/", buf);
__builtin_puts (buf);
canonicalize_path("/a/b/././//c/..////../////d/e/", buf);
__builtin_puts (buf);
canonicalize_path("../a/b", buf);
__builtin_puts (buf);
canonicalize_path("../../a/b", buf);
__builtin_puts (buf);
canonicalize_path("../../../a/b", buf);
__builtin_puts (buf);
canonicalize_path("..///..///..///a/b", buf);
__builtin_puts (buf);
return 0;
}
with canonicalize_path from debugedit.c, it will print:
/a/d/e
/a//d/e
../a/b
a/b
../a/b
/..//a/b
Note, ../../ was killed altogether, ../../../ shrunk into ../ and there are
several cases where multiple //'s are left.
With this patch it prints
/a/d/e
/a/d/e
../a/b
../../a/b
../../../a/b
../../../a/b
Fixed in rpm cvs, will be in rpm-4.4.9-0.2 when built. Thanks for the testcase (added to RHTS) and the patch. Built for rawhide. Do we need this for fc6 and RHEL5? If so can you clone appropriately Unfortunately this patch causes regressions, e.g. glibc doesn't build any longer. In particular, canonicalize_path on say "./netinet" canonicalizes it to "/netinet" rather than "netinet". Working on a fix. Created attachment 153216 [details]
rpm-debugedit-incremental-fix.patch
Incremental patch to fix this bug.
Fixed in rpm cvs. Thanks for the patch. (aside) I still think that path canonicalization on strings needs to be in glibc. I personally have boogered up path canonicalization several times, clearly you have too ;-) Path canonicalization is in glibc, see realpath(3) and canonicalize_file_name(3). But that doesn't simplify just ., .. and multiple //s, but also symlinks, so it is not useful for debugedit purposes. I knew realpath(3), whose behavior is dependent on the path existing on the file system because of getcwd and stat. A quick look at canonicalize_file_name indicates and alternative entry to __realpath, and so has the same behavior. Thanks for the ptr. A pure string canonicalization on path would be useful imho. |
debugedit with rpm-4.4.2-debugpaths.patch breaks libgcj.so.8rh.0.0.debug. Self-contained testcase: #!/bin/sh rm -rf /tmp/debugedit-test mkdir -p /tmp/debugedit-test/{a/b/c,d/e/f} cd /tmp/debugedit-test/a/b/c echo 'int main (void) { return 0; }' > ../../../d/e/f/a.c gcc -g ../../../d/e/f/a.c -o a -O2 cd ../../../ readelf -wi -wl a/b/c/a | sed -n '/DW_AT_\(name.*\.c\|comp_dir\)/p;/^ The \(Directory\|File Name\) Table:/,/^$/p' cp a/b/c/a{,.orig} /usr/lib/rpm/debugedit -b /tmp/debugedit-test/ -d /usr/src/debug/ -l a/b/c/a.list a/b/c/a readelf -wi -wl a/b/c/a | sed -n '/DW_AT_\(name.*\.c\|comp_dir\)/p;/^ The \(Directory\|File Name\) Table:/,/^$/p' As you can see, it messes up the directory table entries, ../../../d/e/f is changed into ../d/e/f and thus after relocation it obviously can't be found, /usr/src/debug/a/b/c/../d/e/f/a.c is not where the file was stored - /usr/src/debug/d/e/f/a.c aka /usr/src/debug/a/b/c/../../../d/e/f/a.c.