Bug 232232
Summary: | usb-webcam with usb-sound compatible mic doesn't work on hotplug | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | kernel | Assignee: | Pete Zaitcev <zaitcev> |
Status: | CLOSED WORKSFORME | QA Contact: | Brian Brock <bbrock> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | cebbert, davej |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-14 15:28:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hans de Goede
2007-03-14 14:56:00 UTC
The comparison with dev looks bogus to me. I have no idea what Takashi was thinking when he wrote it. I'm going to poke him and then we'll see. Well, Takashi says that the code fragment I mentioned is used when several audio devices are present in one USB interface. Odd, but not criminal, as long as the device pointer is not used across disconnects. He asks to try this: diff -r aed6a15c9398 sound/usb/usbaudio.c --- a/sound/usb/usbaudio.c Mon Apr 23 11:54:41 2007 +0200 +++ b/sound/usb/usbaudio.c Mon Apr 23 12:09:12 2007 +0200 @@ -3611,6 +3611,7 @@ static void snd_usb_audio_disconnect(str list_for_each(p, &chip->mixer_list) { snd_usb_mixer_disconnect(p); } + chip->dev = NULL; mutex_unlock(®ister_mutex); snd_card_free_when_closed(card); } else { Unfortunately, despite my current kernel not having the chip->dev = NULL; line I can no longer reproduce this, I guess some other upstream change has fixed this. So I guess this maybe closed, not sure though. I'm closing this so that it doesn't stick out. But yes, I suspect this is random. The patch is not in 2.6.21-1.3126. |