Bug 2323139

Summary:	Review Request: rocm-rpp - ROCm Performance Primitives for computer vision
Product:	[Fedora] Fedora	Reporter:	Tom.Rix
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	alexjnewt, davide, package-review, rocm-packagers-sig, trix
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
URL:	https://github.com/ROCm/%{upstreamname}
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-05 13:47:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom.Rix 2024-11-01 11:03:30 UTC

Spec URL: https://trix.fedorapeople.org/rocm-rpp.spec
SRPM URL: https://trix.fedorapeople.org/rocm-rpp-6.2.0-1.fc42.src.rpm

AMD ROCm Performance Primitives (RPP) library is a comprehensive,                                                                                         
high-performance computer vision library for AMD processors that                                                                                          
have HIP, OpenCL, or CPU backends.

Reproducible: Always

Comment 1 Tom.Rix 2024-11-01 11:09:09 UTC

The earlier request is 
https://bugzilla.redhat.com/show_bug.cgi?id=2259449

I am the original reporter, but my email is no longer valid, so I can not request a repo.

The spec has changed from the end of the earlier bz is to do

%{_libdir}/librpp.so.1{,.*}

As requested.

Comment 2 Fedora Review Service 2024-11-01 11:38:40 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8198753
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323139-rocm-rpp/fedora-rawhide-x86_64/08198753-rocm-rpp/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-11-01 16:17:12 UTC

Approved per the previous review.

Comment 4 Davide Cavalca 2024-11-01 16:17:36 UTC

*** Bug 2259449 has been marked as a duplicate of this bug. ***

Comment 5 Fedora Admin user for bugzilla script actions 2024-11-01 18:29:40 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rocm-rpp