Bug 2323168

Summary: python-toolz fails to build with Python 3.14: AssertionError: is_none: assert should_curry(getattr(operator, k)) == isinstance(v, toolz.curry), k
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-toolzAssignee: Orion Poplawski <orion>
Status: CLOSED WORKSFORME QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: fti-bugs, ksurma, loganjerry, mhroncok, orion
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-27 12:10:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2322407, 2339432, 2339435, 2371672, 2371796, 2371799, 2371827, 2371841, 2371849, 2371852, 2371862, 2371885, 2371886, 2371887, 2371888, 2371889, 2371890, 2371891, 2371892, 2371921, 2371938, 2372026, 2372030, 2372049, 2372104, 2372106, 2372146, 2372173, 2372200, 2372202, 2372239    

Description Karolina Surma 2024-11-01 14:55:27 UTC
python-toolz fails to build with Python 3.14.0a1.

____________________________ test_curried_operator _____________________________

    def test_curried_operator():
        import operator
    
        for k, v in vars(cop).items():
            if not callable(v):
                continue
    
            if not isinstance(v, toolz.curry):
                try:
                    # Make sure it is unary
                    v(1)
                except TypeError:
                    try:
                        v('x')
                    except TypeError:
                        pass
                    else:
                        continue
                    raise AssertionError(
                        'toolz.curried.operator.%s is not curried!' % k,
                    )
>           assert should_curry(getattr(operator, k)) == isinstance(v, toolz.curry), k
E           AssertionError: is_none
E           assert False == True
E            +  where False = should_curry(<built-in function is_none>)
E            +    where <built-in function is_none> = getattr(<module 'operator' from '/usr/lib64/python3.14/operator.py'>, 'is_none')
E            +  and   True = isinstance(<built-in function is_none>, <class 'toolz.functoolz.curry'>)
E            +    where <class 'toolz.functoolz.curry'> = toolz.curry

toolz/tests/test_curried.py:74: AssertionError
=========================== short test summary info ============================
FAILED toolz/tests/test_curried.py::test_curried_operator - AssertionError: i...
================= 1 failed, 202 passed, 1 deselected in 4.00s ==================

https://docs.python.org/3.14/whatsnew/3.14.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.14/fedora-rawhide-x86_64/08189231-python-toolz/

For all our attempts to build python-toolz with Python 3.14, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/package/python-toolz/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.14:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/

Let us know here if you have any questions.

Python 3.14 is planned to be included in Fedora 43.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.14.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2025-02-26 13:14:23 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 2 Karolina Surma 2025-06-11 16:05:16 UTC
*** Bug 2372163 has been marked as a duplicate of this bug. ***

Comment 3 Miro HronĨok 2025-06-19 20:03:39 UTC
This blocks a significant number of packages, increasing severity.

Comment 4 Fedora Fails To Install 2025-06-20 19:49:38 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 5 Orion Poplawski 2025-06-21 17:37:43 UTC
Issue has been reported upstream, but no response yet.  Should we simply ignore the test failures for now?  No idea if they will cause issues elsewhere.

Comment 6 Jerry James 2025-06-25 15:25:20 UTC
Upstream checked in a fix.  I opened a PR at https://src.fedoraproject.org/rpms/python-toolz/pull-request/5 to add their patch, and also to update the License field and the python build macros.

Comment 7 Fedora Fails To Install 2025-06-27 12:10:02 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 43.

Thanks for taking care of it!