Bug 2323548

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8206518
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323548-golang-github-tetratelabs-wazero/fedora-rawhide-x86_64/08206518-golang-github-tetratelabs-wazero/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I need this for github.com/wasilibs/go-re2

Spec is fine, but:

- Can you update it to 1.8.2?
- Do you require or does tinygo require `wazero` binary? Just wanting to make sure in case it's not needed it's easier to track non-binary packages as leaves in the future.

(In reply to Mikel Olasagasti Uranga from comment #2)
> - Do you require or does tinygo require `wazero` binary? Just wanting to
> make sure in case it's not needed it's easier to track non-binary packages
> as leaves in the future.

No, I think not. I just figured it might be useful to have a WASM runtime, since we don't have the Rust one, and this has no dependencies itself to worry about.

Spec URL: https://qulogic.fedorapeople.org/reviews/golang-github-tetratelabs-wazero/golang-github-tetratelabs-wazero.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/golang-github-tetratelabs-wazero/golang-github-tetratelabs-wazero-1.8.2-1.fc42.src.rpm

- Update to 1.8.2

Created attachment 2063470 [details]
The .spec file difference from Copr build 8206518 to 8436343

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8436343
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2323548-golang-github-tetratelabs-wazero/fedora-rawhide-x86_64/08436343-golang-github-tetratelabs-wazero/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks for updating the package.

I would appreciate if you can review https://bugzilla.redhat.com/show_bug.cgi?id=2333638 and https://bugzilla.redhat.com/show_bug.cgi?id=2333639 

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tetratelabs-wazero

Thank you for the review, Mikel. I'll have a look at those reviews soon.

FEDORA-2024-0e9df32da9 (golang-github-tetratelabs-wazero-1.8.2-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0e9df32da9

FEDORA-2024-0e9df32da9 (golang-github-tetratelabs-wazero-1.8.2-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-ce30f2cf4c (golang-github-tetratelabs-wazero-1.8.2-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ce30f2cf4c

FEDORA-2024-5e0a5be4ed has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5e0a5be4ed`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5e0a5be4ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-ce30f2cf4c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ce30f2cf4c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ce30f2cf4c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-5e0a5be4ed (golang-github-tetratelabs-wazero-1.8.2-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-ce30f2cf4c (golang-github-tetratelabs-wazero-1.8.2-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.