Bug 232394
| Summary: | Review Request: pdfedit - A complete pdf document editing solution | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bernard Johnson <bjohnson> |
| Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | orion |
| Target Milestone: | --- | Flags: | manuel.wolfshant:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-19 16:23:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bernard Johnson
2007-03-15 07:05:05 UTC
According to http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets?highlight=%28install%29%7C%28icons%29#head-7ffd8ce2de15fe69c6de937ac04b2b65e80187a1 it would be wise to add a couple of lines in %post GOOD - rpmlint does not return anything either on source or on binary rpm - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum f011d456d5ccbf2b644338ba6ada2294fcca5606 pdfedit-0.2.5.tar.bz2 - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales are treated by the app itself, no presence of %{_datadir}/locale/* in the spec - not relocatable - owns all files and directories that it creates, does not take ownership of foreign files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs [*] - nothing in %doc affects runtime - app is a GUI, desktop file correctly provided and used - no .la./.pc/static files SHOULD - package builds in mock / devel & fc6/ x86_64 - program can be used (does not crash, loads a pdf ..) Bernard, please include the missing scriptlets (see comment #1) and the missing doc folder (or justify why it would not be needed) and I will approve the package. [*] please consider shipping the content of the /doc directory (In reply to comment #2) > Bernard, please include the missing scriptlets (see comment #1) and the missing > doc folder (or justify why it would not be needed) and I will approve the package. I've included the user html docs generated by doxygen. The programmer docs and design docs I did not include. Also fixed the scriptlets. Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/pdfedit.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/pdfedit-0.2.5-2.fc6.src.rpm * Thu Mar 15 2007 Bernard Johnson <bjohnson> - 0.2.5-2 - add scriptlets to update icon cache - add doxygen user docs All reported issued seem fixed, no new ones added, package is APPROVED New Package CVS Request ======================= Package Name: pdfedit Short Description: A complete pdf document editing solution Owners: bjohnson Branches: FC-6 InitialCC: Package Change Request ====================== Package Name: pdfedit New Branches: EL-5 EL-6 Owners: orion tremble CVS done (by process-cvs-requests.py). |