Bug 2324030
| Summary: | Review Request: rust-libhandy - Rust bindings for libhandy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Kalev Lember <klember> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | klember, package-review |
| Target Milestone: | --- | Flags: | klember:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/libhandy | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-11-14 15:26:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2024-11-05 21:14:09 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8217155 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324030-rust-libhandy/fedora-rawhide-x86_64/08217155-rust-libhandy/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking for review. Looks like it's a re-review of a recently retired package - just out of curiosity, what needs it now? https://github.com/samcday/phrog needs it until it can be ported to GTK4 (see progress in issue https://github.com/samcday/phrog/issues/23 ). Ah, I see. I wonder if it would make sense to let unused rust packages linger around for a little while longer before retiring in case some users come up in the future. Fedora review rust-libhandy-0.11.1-1.fc41.src.rpm 2024-10-07
$ rpmlint rust-libhandy*
============================================= rpmlint session starts =============================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 7
rust-libhandy+default-devel.noarch: W: no-documentation
rust-libhandy+v1_0-devel.noarch: W: no-documentation
rust-libhandy+v1_2-devel.noarch: W: no-documentation
rust-libhandy+v1_4-devel.noarch: W: no-documentation
rust-libhandy+v1_6-devel.noarch: W: no-documentation
rust-libhandy-devel.noarch: W: no-documentation
======= 7 packages and 0 specfiles checked; 0 errors, 6 warnings, 32 filtered, 0 badness; has taken 0.6 s ========
+ OK
! needs attention
+ rpmlint output looks good
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (LICENSE) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
SHA512 (libhandy-0.11.1.crate) = 5cbc1f7e000fc1d83dc0c8fb2fa07a140fdf65cc93e5a39bb6a7370f0b2995d3388ae32ca1c17b0c162c1dca636752e5b0aac3b22117d4ad70246aca14ddbf30
SHA512 (Download/libhandy-0.11.1.crate) = 5cbc1f7e000fc1d83dc0c8fb2fa07a140fdf65cc93e5a39bb6a7370f0b2995d3388ae32ca1c17b0c162c1dca636752e5b0aac3b22117d4ad70246aca14ddbf30
+ Package builds in mock (when locally installing rust-libhandy-sys dep that's approved, not yet built in rawhide)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files (LICENSE is listed twice but that's expected with the rust2rpm generator)
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+ Package does not depend on deprecated packages
APPROVED
Thank you for the review! Unretirement request: https://pagure.io/releng/issue/12458 FEDORA-2024-2954d32134 (rust-libhandy-0.11.1-1.fc42 and rust-libhandy-sys-0.11.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2954d32134 FEDORA-2024-2954d32134 (rust-libhandy-0.11.1-1.fc42 and rust-libhandy-sys-0.11.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |