Bug 2325318

Summary:	Review Request: aqute-bnd-epel - BND Tool
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://bnd.bndtools.org/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2325260
Bug Blocks:	1914423, 2325258

Description Michel Lind 2024-11-11 20:57:12 UTC

Spec URL: https://salimma.fedorapeople.org/aqute-bnd-epel.spec
SRPM URL: https://salimma.fedorapeople.org/aqute-bnd-epel-6.3.1-11.1.fc41.src.rpm

Description:
The bnd tool helps you create and diagnose OSGi bundles.
The key functions are:
- Show the manifest and JAR contents of a bundle
- Wrap a JAR so that it becomes a bundle
- Create a Bundle from a specification and a class path
- Verify the validity of the manifest entries
The tool is capable of acting as:
- Command line tool
- File format
- Directives
- Use of macros

Fedora Account System Username: salimma

Comment 1 Michel Lind 2024-11-11 20:58:18 UTC

*** Bug 2325259 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Review Service 2024-11-11 21:06:46 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8244153
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325318-aqute-bnd-epel/fedora-rawhide-x86_64/08244153-aqute-bnd-epel/fedora-review/review.txt

Found issues:

- Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local
  Read more: https://fedoraproject.org/wiki/Packaging:Java
- No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21
  Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- No javadoc subpackage present
  Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-11-11 21:27:20 UTC

COPR build: https://copr.fedorainfracloud.org/coprs/salimma/antlr4-el10/build/8244161/

Comment 4 Michel Lind 2024-11-11 21:38:35 UTC

Diff from c10s spec

https://paste.centos.org/view/9dc4275e

Comment 5 Neal Gompa 2024-11-11 21:44:14 UTC

Review notes:

* Packaging looks reasonable for an EPEL fork with a subset of packages
* Licensing is correctly handled
* Package builds and installs
* No serious issues from rpmlint

FYI: In the future, attach diffs to the bug rather than linking to paste.centos.org, since pastes expire after a single day.

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2024-11-11 22:15:38 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/aqute-bnd-epel