Bug 232617 (perl-Sys-SigAction)
| Summary: | Review Request: perl-Sys-SigAction - Perl extension for Consistent Signal Handling | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | tremble |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-23 16:44:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andreas Thienemann
2007-03-16 13:23:35 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ba520c175ea5c41950f53e60801da476 Sys-SigAction-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/mask.......ok
t/name.......ok
t/nested.....ok
t/number.....ok
t/safe.......
NOTE: Setting safe=>1... with masked signals does not seem to work.
The problem is that the masked signals are not masked, but when
safe=>0 they are. See mask.t for how we could try it.
If you have an application for safe=>1 and can come up with
a test that works in the context of this module's installation
please send me an update. To safe.t that tests it.
Lincoln
ok
t/timeout....ok
All tests successful.
Files=6, Tests=33, 6 wallclock secs ( 1.16 cusr + 0.08 csys = 1.24 CPU)
+ Provides: perl(Sys::SigAction) = 0.10
APPROVED.
New Package CVS Request ======================= Package Name: perl-Sys-SigAction Short Description: Read extension for Consistent Signal Handling Owners: andreas Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list Thx for the review. Package has been built for devel, FC-5 and FC-6. Closing as NEXTRELEASE. Package Change Request ====================== Package Name: perl-Sys-SigAction New Branches: EL-5 Owners: tremble Have attempted to contact the Fedora owner #574431 no reply cvs done. |