Bug 232623
Summary: | Review Request: perl-HTML-CalendarMonthSimple - Perl Module for Generating HTML Calendars | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | cweyl:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-07-24 23:20:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Andreas Thienemann
2007-03-16 13:38:43 UTC
Missing a BR on perl(Date::Calc). + source files match upstream: 2f9fcad2627890cc11ab5c3cd3c986cf HTML-CalendarMonthSimple-1.25.tar.gz 2f9fcad2627890cc11ab5c3cd3c986cf ../HTML-CalendarMonthSimple-1.25.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. (Entire license grant is in README & CalendarMonthSimple.pm) + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly O noarch -- no debuginfo package + rpmlint is silent. + final provides and requires are sane: ** perl-HTML-CalendarMonthSimple-1.25-1.fc6.noarch.rpm == rpmlint == provides perl(HTML::CalendarMonthSimple) perl-HTML-CalendarMonthSimple = 1.25-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Date::Calc) perl(strict) + %check is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. Add perl(Date::Calc) -- post-import -- and the package is: APPROVED New Package CVS Request ======================= Package Name: perl-HTML-CalendarMonthSimple Short Description: Perl Module for generating HTML Calendard Owners: andreas Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list ping? I'm assuming this bug is closable now...? Closing for the reporter. Thanks. Missed the ping in all the bugzilla mail or so. :/ Not a problem -- just wanted to get it off my frontpage ;) |