Bug 232624
Summary: | Review Request: perl-ConfigReader - Read directives from a configuration file | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | orion |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-23 10:21:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Andreas Thienemann
2007-03-16 13:42:33 UTC
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 469a77797740e7dd70ab902d0ac8081d ConfigReader-0.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: perl(ConfigReader::DirectiveStyle) = 0.5 perl(ConfigReader::Spec) = 0.5 perl(ConfigReader::Values) = 0.5 APPROVED. New Package CVS Request ======================= Package Name: perl-ConfigReader Short Description: Read directives from a configuration file Owners: andreas Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list Thanks for the review. Package has been built for FC-5, FC-6 and rawhide. I'd like to see this in epel (5 and 6). Andreas - would you want to be the owner there? |