Bug 2326622
| Summary: | Review Request: steam-devices - Provides udev rules for Controller support for Steam/Lutris/Wine/other platforms | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn W Dunn <sfalken> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/ValveSoftware/steam-devices/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn W Dunn
2024-11-15 21:48:27 UTC
Taking this review. Copr build: https://copr.fedorainfracloud.org/coprs/build/8269481 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326622-steam-devices/fedora-rawhide-x86_64/08269481-steam-devices/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The Spec URL needs to be pointing to the raw spec file: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/srpm-builds/08269444/steam-devices.spec (In reply to Neal Gompa from comment #3) > The Spec URL needs to be pointing to the raw spec file: > https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/ > srpm-builds/08269444/steam-devices.spec Fixed. The URLs return 404 now, so new builds are needed. Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-rawhide-x86_64/08546981-steam-devices/steam-devices.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-rawhide-x86_64/08546981-steam-devices/steam-devices-1.0.0.100%5Egit20240522.0.e2971e4-4.fc42.src.rpm Created attachment 2066701 [details]
The .spec file difference from Copr build 8269481 to 8546985
Copr build: https://copr.fedorainfracloud.org/coprs/build/8546985 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326622-steam-devices/fedora-rawhide-x86_64/08546985-steam-devices/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Can you submit a new build to copr, it looks like your latest one was reaped away... SPEC URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-42-x86_64/08702374-steam-devices/steam-devices.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-42-x86_64/08702374-steam-devices/steam-devices-1.0.0.100%5Egit20240522.0.e2971e4-4.fc42.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8702384 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326622-steam-devices/fedora-rawhide-x86_64/08702384-steam-devices/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > steam-devices.noarch: W: incoherent-version-in-changelog 1.0.0.78^git20240522.0.e2971e4-1 ['1.0.0.100^git20240522.0.e2971e4-4.fc43', '1.0.0.100^git20240522.0.e2971e4-4']
This is the result of version-release and the changelog entries not agreeing. Release should be set back to 1, the date in the changelog needs to be fixed, and the the version in changelog should be "1.0.0.100^git20240522.0.e2971e4-1".
To clarify, I expect Release to be "1%{?dist}".
SPEC URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-rawhide-x86_64/08736970-steam-devices/steam-devices.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/steam-devices/fedora-rawhide-x86_64/08736970-steam-devices/steam-devices-1.0.0.100%5Egit20240522.0.e2971e4-1.fc43.src.rpm Created attachment 2079197 [details]
The .spec file difference from Copr build 8702384 to 8737004
Copr build: https://copr.fedorainfracloud.org/coprs/build/8737004 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326622-steam-devices/fedora-rawhide-x86_64/08737004-steam-devices/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This package looks good now, there's only one thing left:
> * Fri Nov 15 2024 Shawn W. Dunn <sfalken> 1.0.0.100^git20240522.0.e2971e4-1
The date needs to be updated to today's date before your import it.
PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/steam-devices |