Bug 232703
| Summary: | Review Request: perl-IO-Compress-Bzip2 - Write bzip2 files/buffers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
| Component: | Package Review | Assignee: | Andreas Thienemann <andreas> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | robin.norwood |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-27 22:20:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 228537, 232702 | ||
| Bug Blocks: | |||
|
Description
Steven Pritchard
2007-03-16 18:20:48 UTC
+ source files match upstream: 5ddb54bf0f91187786952cfbcf66cd00 IO-Compress-Bzip2-2.004.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + license is "GPL or Artistic". + latest version is being packaged. - BuildRequires are somewhat proper. perl(IO::Compress::Base) is however not available. + compiler flags are appropriate. o noarch package. $RPM_OPT_FLAGS are not necessary. + %clean is present. + package installs properly o noarch package. no debuginfo package is being generated. + rpmlint is silent. + final provides and requires are sane: == provides perl(IO::Compress::Adapter::Bzip2) = 2.004 perl(IO::Compress::Bzip2) = 2.004 perl(IO::Uncompress::Adapter::Bunzip2) = 2.004 perl(IO::Uncompress::Bunzip2) = 2.004 perl-IO-Compress-Bzip2 = 2.004-1.fc7 == requires perl(:MODULE_COMPAT_5.8.8) perl(Compress::Raw::Bzip2) >= 2.004 perl(Exporter) perl(IO::Compress::Adapter::Bzip2) >= 2.004 perl(IO::Compress::Base) >= 2.004 perl(IO::Compress::Base::Common) >= 2.004 perl(IO::Uncompress::Adapter::Bunzip2) >= 2.004 perl(IO::Uncompress::Base) >= 2.004 perl(bytes) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 - %check is present and all supported tests pass. However, Test::POD would be useful as a BR + no shared libraries are added to the regular linker search paths. + no duplication of system libraries. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. The package looks okay and I'd approve it. Unfortunately, it does not build in mock as of right now. As soon as perl(IO::Compress::Base) 2.004 or higher is available I'll approve that package. It looks like perl-IO-Compress-Base 2.004 is in rawhide. Can I get an official approval for this package? Oh, wait, perl-IO-Compress-Bzip2 is there too. so we scrap this? I reviewed and approved perl-IO-Compress-Bzip2 as part of bug 243016 earlier this month. I had no idea this bug existed. Let's chalk it up to merge confusion then and move on... |