Bug 2327093
| Summary: | Review Request: rust-rustc-demangle-capi - C API for the rustc-demangle crate | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | decathorpe, farchord, package-review | ||||||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://crates.io/crates/rustc-demangle-capi | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2025-03-16 00:29:54 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ben Beasley
2024-11-18 19:17:01 UTC
Created attachment 2058562 [details]
Configuration file for rust2rpm
Some minor manual changes to the spec file were still needed to get the License field and %files list in the rustc-demangle-capi subpackage right, and to add a rustc-demangle-capi-devel subpackage.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8277182 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327093-rust-rustc-demangle-capi/fedora-rawhide-x86_64/08277182-rust-rustc-demangle-capi/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Not committing (yet) to do a formal review of this package - just wanted to ask whether it might make sense to rename the built "binary" package and the manually added "-devel" package?
The shipped library is "librustc_demangle.so", so I think the "expected" package names would be "librustc_demangle" and "librustc_demangle-devel".
Having the package names be "rustc-demangle-capi" and "rustc-demangle-capi-devel" would be a bit weird ("-n %crate" is just the name generated by rust2rpm, but for shared libraries, we override this in almost all existing packages).
I wouldn’t claim that we have any real consistency in how we name packages providing shared libraries across Fedora as a whole, but I don’t see any reason not to implement that suggestion. Created attachment 2058563 [details]
Updated configuration file for rust2rpm
New Spec URL: https://music.fedorapeople.org/20241118/rust-rustc-demangle-capi.spec New SRPM URL: https://music.fedorapeople.org/20241118/rust-rustc-demangle-capi-0.1.0-1.fc41.src.rpm Created attachment 2058577 [details]
The .spec file difference from Copr build 8277182 to 8277214
Copr build: https://copr.fedorainfracloud.org/coprs/build/8277214 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327093-rust-rustc-demangle-capi/fedora-rawhide-x86_64/08277214-rust-rustc-demangle-capi/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. The way the shared library is build / installed with cargo-c and handled in the spec file looks correct. === ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account 🫤 license files are included with %license in %files (manually included from upstream for now) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! Thank you for the review! https://release-monitoring.org/project/377193/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustc-demangle-capi FEDORA-2025-0ab903f938 (rust-rustc-demangle-capi-0.1.0-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-0ab903f938 FEDORA-2025-0ab903f938 (rust-rustc-demangle-capi-0.1.0-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-aa6e3730ee (python-uharfbuzz-0.46.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-aa6e3730ee FEDORA-2025-823bd7664f (rust-rustc-demangle-capi-0.1.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-823bd7664f FEDORA-2025-aa6e3730ee (python-uharfbuzz-0.46.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-592d32c7f9 (rust-rustc-demangle-capi-0.1.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-592d32c7f9 FEDORA-2025-7833b1703c (rust-rustc-demangle-capi-0.1.0-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7833b1703c FEDORA-2025-54d655e960 (python-uharfbuzz-0.46.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-54d655e960 FEDORA-EPEL-2025-8fb433e522 (rust-rustc-demangle-capi-0.1.0-2.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-8fb433e522 FEDORA-EPEL-2025-b1e0d7b740 (rust-rustc-demangle-capi-0.1.0-2.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b1e0d7b740 FEDORA-2025-592d32c7f9 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-592d32c7f9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-592d32c7f9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-8fb433e522 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-8fb433e522 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-b1e0d7b740 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b1e0d7b740 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-7833b1703c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7833b1703c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7833b1703c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-823bd7664f has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-823bd7664f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-823bd7664f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-54d655e960 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-54d655e960 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-54d655e960 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-823bd7664f (rust-rustc-demangle-capi-0.1.0-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-8fb433e522 (rust-rustc-demangle-capi-0.1.0-2.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-7833b1703c (rust-rustc-demangle-capi-0.1.0-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-b1e0d7b740 (rust-rustc-demangle-capi-0.1.0-2.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-592d32c7f9 (rust-rustc-demangle-capi-0.1.0-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |