Bug 2327722

Summary: Review Request: rust-libz-rs-sys - Memory-safe zlib implementation written in rust
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/libz-rs-sys
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-08 15:22:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ben Beasley 2024-11-20 21:06:55 UTC
Spec URL: https://music.fedorapeople.org/rust-libz-rs-sys.spec
SRPM URL: https://music.fedorapeople.org/rust-libz-rs-sys-0.4.0-1.fc41.src.rpm
Description: A memory-safe zlib implementation written in rust.
Fedora Account System Username: music

This relies on https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bcc5bbd5f, which is in the Rawhide buildroot but has not yet reached a compose. Therefore, in the very short term, it will be necessary to pass --mock-options=--enablerepo=local to the fedora-review too.

Despite the -sys name, this doesn’t wrap a C or C++ library; instead, it exposes the functionality of the zlib-rs crate through C-ABI (extern "C-unwind") functions with an API generally compatible with those of -sys crate wrappers for other (non-Rust) zlib implementations.

This is required in order to unhide the zlib-rs and libz-rs-sys features in our rust-flate2 package, which would allow uv to use the zlib-r2 backend for flate2, which upstream recently switched to instead of the zlib-ng backend (https://github.com/astral-sh/uv/pull/9184).

Comment 1 Fedora Review Service 2024-11-20 21:07:19 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/rust-libz-rs-sys-0.4.0-1.fc41.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2024-11-20 21:27:35 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-11-20 21:30:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8288136
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327722-rust-libz-rs-sys/fedora-rawhide-x86_64/08288136-rust-libz-rs-sys/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-12-08 14:47:31 UTC
Package was generated with rust2rpm, simplifying the review.

Package is as generated by rust2rpm with no modifications.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Ben Beasley 2024-12-08 14:58:57 UTC
Thank you for the review!

https://release-monitoring.org/project/375770/

Comment 6 Fedora Admin user for bugzilla script actions 2024-12-08 14:59:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libz-rs-sys

Comment 7 Fedora Update System 2024-12-08 15:17:41 UTC
FEDORA-2024-f5d0ecc015 (rust-libz-rs-sys-0.4.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f5d0ecc015

Comment 8 Fedora Update System 2024-12-08 15:22:25 UTC
FEDORA-2024-f5d0ecc015 (rust-libz-rs-sys-0.4.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-12-09 11:43:25 UTC
FEDORA-2024-aa2e893cac (rust-flate2-1.0.35-2.fc41, rust-libz-rs-sys-0.4.0-1.fc41, and 1 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-aa2e893cac

Comment 10 Fedora Update System 2024-12-09 12:22:22 UTC
FEDORA-EPEL-2024-7a69b2dfa0 (rust-flate2-1.0.35-2.el10_0 and rust-libz-rs-sys-0.4.0-1.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7a69b2dfa0

Comment 11 Fedora Update System 2024-12-09 12:24:12 UTC
FEDORA-EPEL-2024-3991f5b7dc (rust-flate2-1.0.35-2.el9 and rust-libz-rs-sys-0.4.0-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3991f5b7dc

Comment 12 Fedora Update System 2024-12-09 14:44:02 UTC
FEDORA-2024-5da363ef3d (rust-flate2-1.0.35-2.fc40, rust-libz-rs-sys-0.4.0-1.fc40, and 1 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5da363ef3d

Comment 13 Fedora Update System 2024-12-10 01:38:57 UTC
FEDORA-EPEL-2024-7a69b2dfa0 has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7a69b2dfa0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-12-10 01:49:09 UTC
FEDORA-EPEL-2024-3991f5b7dc has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3991f5b7dc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-12-10 02:03:06 UTC
FEDORA-2024-aa2e893cac has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-aa2e893cac`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-aa2e893cac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-12-10 05:15:47 UTC
FEDORA-2024-5da363ef3d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5da363ef3d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5da363ef3d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-12-19 04:00:18 UTC
FEDORA-2024-5da363ef3d (rust-flate2-1.0.35-2.fc40, rust-libz-rs-sys-0.4.0-1.fc40, and 1 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-12-19 04:06:47 UTC
FEDORA-2024-aa2e893cac (rust-flate2-1.0.35-2.fc41, rust-libz-rs-sys-0.4.0-1.fc41, and 1 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-12-19 04:31:41 UTC
FEDORA-EPEL-2024-7a69b2dfa0 (rust-flate2-1.0.35-2.el10_0 and rust-libz-rs-sys-0.4.0-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2024-12-19 04:40:00 UTC
FEDORA-EPEL-2024-3991f5b7dc (rust-flate2-1.0.35-2.el9 and rust-libz-rs-sys-0.4.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.