Bug 2327938
| Summary: | Review Request: python-cmdkit - library for developing command-line applications in Python | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Wright <jonathan> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | benson_muite, ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://cmdkit.readthedocs.io/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-12-12 01:04:45 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Wright
2024-11-22 00:28:19 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8299938 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327938-python-cmdkit/fedora-rawhide-x86_64/08299938-python-cmdkit/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I've made upstream aware of the python-toml deprecation and they'll be shifting to a different library. Let's not hold up this package over that please. SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit/fedora-rawhide-x86_64/08299951-python-cmdkit/python-cmdkit-2.7.5-1.fc42.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit/fedora-rawhide-x86_64/08299951-python-cmdkit/python-cmdkit.spec Created attachment 2059223 [details]
The .spec file difference from Copr build 8299938 to 8299955
Copr build: https://copr.fedorainfracloud.org/coprs/build/8299955 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327938-python-cmdkit/fedora-rawhide-x86_64/08299955-python-cmdkit/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. (In reply to Jonathan Wright from comment #2) > I've made upstream aware of the python-toml deprecation and they'll be > shifting to a different library. Let's not hold up this package over that > please. > I don't see any indication in the upstream GitHub project that this is being tracked. https://github.com/glentner/CmdKit/issues Without that and some acknowledgement they are working on switching, I don't think we can ignore the deprecated dependency. > I don't see any indication in the upstream GitHub project that this is being
> tracked.
I spoke with the dev in-person today at SC24 and also in discord a few minutes ago.
I'll get an issue opened on GH and have him acknowledge it there to satisfy this.
Here ya go @ngompa13 https://github.com/glentner/hypershell/issues/33 Is it possible for you to vendor the module in the package until it's replaced? Why? python-toml, while deprecated, is still present in Fedora. Possibly a patch could be applied - have not tested, but it seems a few lines need to be changed: https://github.com/glentner/CmdKit/pull/24 Upstream has released a new version that does not use python-toml: https://github.com/glentner/CmdKit/releases SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08374272-python-cmdkit/python-cmdkit-2.7.6-1.fc42.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08374272-python-cmdkit/python-cmdkit.spec Created attachment 2061996 [details]
The .spec file difference from Copr build 8299955 to 8374275
Copr build: https://copr.fedorainfracloud.org/coprs/build/8374275 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327938-python-cmdkit/fedora-rawhide-x86_64/08374275-python-cmdkit/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed correctly * No serious issues from rpmlint Things to fix on import: > #%%tox / %%pytest / %%pyproject_check_import ... This should just be deleted > * Tue Dec 10 2024 Jonathan Wright <jonathan> - 2.7.6 This should use "2.7.6-1" to be compliant with our changelog format rules. Other than that, this looks good, so... PACKAGE APPROVED. (In reply to Fedora Review Service from comment #15) > > Found issues: > > - python3-pytest7 is deprecated, you must not depend on it. > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating- > packages/ > > Please know that there can be false-positives. > Oof, okay, can this be moved to a newer pytest? The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cmdkit I'm not sure why but python-pytest is pointing to pytest7 here which is what CI is complaining about. Will look into that. pytest7 is a false positive FEDORA-2024-4ad9f50e6e (python-cmdkit-2.7.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ad9f50e6e FEDORA-2024-4ad9f50e6e (python-cmdkit-2.7.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |