Bug 232816

Good:
+ Local build works fine.
+ Tar ball matches with upstream.
+ License Ok.
+ Mock build works fine.
+ Rpmlint of source rpm quite.
+ Rpmlint on binary rpm quite.

Bad:
- Source0 URL shows to wrong location.
- Devel RPM contains no docs.
- Devel RPM need Required to pkgconfig

http://palevo.sgu.ru/mockbuild/6/SPECS/libnetfilter_log.spec
http://palevo.sgu.ru/mockbuild/6/SRPMS/libnetfilter_log-0.0.13-2.fc6.src.rpm

Good:
+ Tar ball matches with upstream.

Bad:
- You have put the BuildRequires to pkgconfig to the main package, but the
BuildRequires is required for the devel subpackage.

I am almost completely sure that pkgconfig is required to build this package as
a whole, that's why I added it to the BuildRequires of main package.

Jochen, can you say something here so I'd push this further? Thanks.

Excluse me for the delay. I have make a text with a mock build and can tell you,
that you don't need pkgconfig as a BR for the main package.

Is there any way to skip building -devel subpackage?
If yes and we'll skip -devel, aren't we still need pkgconfig to do the build
(yes, we need, because the build step is common for both packages).

That said, is there any point in having BuildRequires for subpackages, at all?

(In reply to comment #3)
> Good:
> + Tar ball matches with upstream.
> 
> Bad:
> - You have put the BuildRequires to pkgconfig to the main package, but the
> BuildRequires is required for the devel subpackage.

BuildRequires are not for the main or the devel package, they are 
for the source package.

Here indeed pkgconfig is not needed as a BuildRequires because the
libnfnetlink libs is found with:
AC_CHECK_LIB(nfnetlink, nfnl_subsys_open, AC_MSG_RESULT(found),
AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed]))
AC_CHECK_HEADER([libnfnetlink/linux_nfnetlink.h], [AC_MSG_RESULT([found])],
[AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])])

In general it is better to use pkgconfig instead, if available
(it is better for multilibs, for dependencies and allows to
have different subdirectories for different versions). So it 
would be better, in my opinion, to have something along:

PKG_CHECK_MODULES([NFNETLINK],[libnfnetlink >= 0.0.16],,
[
AC_CHECK_LIB(nfnetlink, nfnl_subsys_open, [NFNETLINK_LIBS=-lnfnetlink
AC_MSG_RESULT(found)], AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed]))
AC_CHECK_HEADER([libnfnetlink/linux_nfnetlink.h], [AC_MSG_RESULT([found])],
[AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])])
])

And in 
src/Makefile.am, replace -lnfnetlink with NFNETLINK_LIBS, and add 
NFNETLINK_CFLAGS to AM_CFLAGS

This is to be tested, and for upstream, of course.

Also in top level Makefile.am 
LINKOPTS = -lnfnetlink
is unuseful

Also in src/Makefile.am 
AM_CFLAGS = -fPIC -Wall
is wrong, since -fPIC is added if needed by libtool and -Wall is
not portable.

OK, you are right, so I can APPROVED your package.

Patrice, I'll add this to CVS first, then will fix the issues you've mentioned.

New Package CVS Request
=======================
Package Name: libnetfilter_log
Short Description: Netfilter logging userspace library
Owners: i
Branches: FC-6 F-7
InitialCC: 

cvs done