Bug 2328456

Summary: Review Request: node-gyp - Node.js native addon build tool
Product: [Fedora] Fedora Reporter: Michael Cronenworth <mike>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/nodejs/node-gyp
Whiteboard: Unretirement
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2328457    

Description Michael Cronenworth 2024-11-23 04:59:24 UTC
Spec URL: https://michael.cronenworth.com/RPMS/node-gyp.spec
SRPM URL: https://michael.cronenworth.com/RPMS/node-gyp-10.2.0-0.1.fc41.src.rpm
Description: Node.js native addon build tool
Fedora Account System Username: mooninite

This review is to unretire the package. The 'zwave-js-ui' package requires this package. I will be opening a separate package review for 'zwave-js-ui' soon.

Comment 1 Fedora Review Service 2024-11-23 05:04:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8305692
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328456-node-gyp/fedora-rawhide-x86_64/08305692-node-gyp/fedora-review/review.txt

Found issues:

- License file LICENSE.APACHE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/node-gyp
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Package Review 2025-11-24 00:45:20 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Michael Cronenworth 2025-12-02 15:33:35 UTC
I'd still like to get this in. I recognize I need to update to the latest version.

Comment 4 Michael Cronenworth 2026-01-31 20:08:51 UTC
Spec URL: https://michael.cronenworth.com/RPMS/node-gyp.spec
SRPM URL: https://michael.cronenworth.com/RPMS/node-gyp-12.2.0-0.1.fc44.src.rpm

Updated to the latest release.