Bug 2328493
| Summary: | Review Request: rust-writeable - More efficient alternative to fmt::Display | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://crates.io/crates/writeable | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2024-12-10 20:40:45 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ben Beasley
2024-11-23 18:45:48 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8306808 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328493-rust-writeable/fedora-rawhide-x86_64/08306808-rust-writeable/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8306807 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328493-rust-writeable/fedora-rawhide-x86_64/08306807-rust-writeable/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I should have submitted 0.5.5 instead. Version 0.6.0 is associated with the icu4x 2.0.0 beta stack. We need to package a version of writeable that is compatible with the current stable releases of the icu_* crates. New Spec URL: https://music.fedorapeople.org/20241127/rust-writeable.spec New SRPM URL: https://music.fedorapeople.org/20241127/rust-writeable-0.5.5-1.fc41.src.rpm Created attachment 2060176 [details]
Updated configuration file for rust2rpm
Created attachment 2060177 [details]
The .spec file difference from Copr build 8306808 to 8320607
Copr build: https://copr.fedorainfracloud.org/coprs/build/8320607 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328493-rust-writeable/fedora-rawhide-x86_64/08320607-rust-writeable/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. I am a bit confused why the example code uses a crate that is obviously targeted at benchmarks, but oh well. This package is affected by tools confusing the Unicode-3.0 license for Unicode-DFS-2016. The license text is for Unicode-3.0, matching the crate metadata. (I need to check whether updating the SPDX license data bundled in askalono would fix this.) ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged (0.5 needed, 0.6 update not possible yet) ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! (In reply to Fabio Valentini from comment #7) > I am a bit confused why the example code uses a crate that is obviously > targeted at benchmarks, but oh well. Examples using icu_benchmark_macros is indeed an odd choice, especially because that crate is supposed to be for internal use, and nothing documents *why* they are there. This habit appears to be consistent across examples in many icu4x crates. I guess one alternative approach would be to sed-patch the examples to remove or comment any lines with "icu_benchmark_macros::". That would probably work, and might be slightly easier than removing examples/ (and later, patching Cargo.toml to remove references to the examples). > This package is affected by tools confusing the Unicode-3.0 license for > Unicode-DFS-2016. The license text is for Unicode-3.0, matching the crate > metadata. (I need to check whether updating the SPDX license data bundled in > askalono would fix this.) 👍 https://release-monitoring.org/project/375844/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-writeable FEDORA-2024-e5a862e751 (rust-writeable-0.5.5-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e5a862e751 FEDORA-2024-e5a862e751 (rust-writeable-0.5.5-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-6e97b9288a (rust-icu_collections-1.5.0-1.fc41 and rust-writeable-0.5.5-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e97b9288a FEDORA-2024-b6caf658a2 (rust-icu_collections-1.5.0-1.fc40 and rust-writeable-0.5.5-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b6caf658a2 FEDORA-2024-6e97b9288a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6e97b9288a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e97b9288a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b6caf658a2 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b6caf658a2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b6caf658a2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-d4da7c69d0 (rust-icu_collections-1.5.0-1.el9 and rust-writeable-0.5.5-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d4da7c69d0 FEDORA-EPEL-2024-d2640ac5c0 (rust-displaydoc-0.2.5-3.el10_0, rust-icu_collections-1.5.0-1.el10_0, and 1 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d2640ac5c0 FEDORA-EPEL-2024-d4da7c69d0 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d4da7c69d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-d2640ac5c0 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d2640ac5c0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b6caf658a2 (rust-icu_collections-1.5.0-1.fc40 and rust-writeable-0.5.5-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-6e97b9288a (rust-icu_collections-1.5.0-1.fc41 and rust-writeable-0.5.5-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-d4da7c69d0 (rust-icu_collections-1.5.0-1.el9 and rust-writeable-0.5.5-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-d2640ac5c0 (rust-displaydoc-0.2.5-3.el10_0, rust-icu_collections-1.5.0-1.el10_0, and 1 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report. |