Bug 2328689

Summary: Review Request: ghc-generic-lens-core - Generically derive traversals, lenses and prisms
Product: [Fedora] Fedora Reporter: Frank Dedden <frank>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: haskell-devel, package-review
Target Milestone: ---Flags: petersen: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://hackage.haskell.org/package/generic-lens-core
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-05-04 10:37:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-11-25 15:14:34 UTC
Spec URL: https://fdedden.fedorapeople.org/ghc-generic-lens-core.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-generic-lens-core-2.2.1.0-1.fc42.src.rpm

Description:
This library uses GHC.Generics to derive efficient optics (traversals, lenses
and prisms) for algebraic data types in a type-directed way, with a focus on
good type inference and error messages when possible.

This package is the shared internal logic of the
'<https://hackage.haskell.org/package/generic-lens generic-lens>' and
'<https://hackage.haskell.org/package/generic-optics generic-optics>'
libraries.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-11-25 15:14:37 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=126248378

Comment 2 Fedora Review Service 2024-11-25 15:23:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8311331
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328689-ghc-generic-lens-core/fedora-rawhide-x86_64/08311331-ghc-generic-lens-core/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jens Petersen 2025-04-18 11:10:38 UTC
Package is APPROVED

- BSD3 license
- pristine cabal-rpm generated spec file
- complies with Fedora and Haskell packaging guidelines

Comment 4 Fedora Admin user for bugzilla script actions 2025-05-04 10:13:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-generic-lens-core