Bug 2328742

Summary: Review Request: python-azure-mgmt-mysqlflexibleservers - The Microsoft Azure Mysqlflexibleservers Management Client Library
Product: [Fedora] Fedora Reporter: Jeremy Cline <jeremy>
Component: Package ReviewAssignee: Ben Beasley <code>
Status: RELEASE_PENDING --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bala12352, code, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: code: fedora-review+
Hardware: All   
OS: Linux   
URL: https://pypi.org/project/azure-mgmt-mysqlflexibleservers/
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeremy Cline 2024-11-25 18:40:32 UTC 
Spec URL: https://jcline.fedorapeople.org/new-packages/python-azure-mgmt-mysqlflexibleservers.spec
SRPM URL: https://jcline.fedorapeople.org/new-packages/python-azure-mgmt-mysqlflexibleservers-1.0.0~b2-1.fc42.src.rpm
Description: The Microsoft Azure Mysqlflexibleservers Management Client Library. Part of the Python Azure SDK.
Fedora Account System Username: jcline

Note: this is a dependency of azure-cli-v2.67; there's a newer beta available, but azure-cli pins this version.
Comment 1 Fedora Review Service 2024-11-25 18:43:29 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8312504
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328742-python-azure-mgmt-mysqlflexibleservers/fedora-rawhide-x86_64/08312504-python-azure-mgmt-mysqlflexibleservers/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Bala 2024-12-18 23:08:08 UTC 
Hi Jeremy,
This is my preliminary review of the package. The spec file looks good and didn't complain about any errors when I ran fedora-review on the bugzilla.
Manually checked the must items with help of fedora-packaging guide. Someone else can review this once again and recheck if the review is done correctly.

Regards,
Bala

------------------------------------

Full review

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 14 files have unknown license. Detailed output of
     licensecheck in /home/azureuser/2328742-python-azure-mgmt-
     mysqlflexibleservers/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13,
     /usr/lib/python3.13/site-packages
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.13/site-
     packages/azure(python3-azure-ai-formrecognizer, python3-azure-mgmt-
     iotcentral, python3-azure-ai-textanalytics, python3-azure-mgmt-search,
     python3-azure-mgmt-extendedlocation, python3-azure-mgmt-batch,
     python3-azure-appconfiguration, python3-azure-mgmt-databoxedge,
     python3-azure-mgmt-media, python3-azure-mgmt-containerservice,
     python3-azure-mgmt-iothubprovisioningservices, python3-azure-mgmt-msi,
     python3-azure-mgmt-imagebuilder, python3-azure-mgmt-servicelinker,
     python3-azure-synapse-accesscontrol, python3-azure-mgmt-
     servicefabricmanagedclusters, python3-azure-mgmt-containerregistry,
     python3-azure-mgmt-devtestlabs, python3-azure-mgmt-sqlvirtualmachine,
     python3-azure-common, python3-azure-mgmt-applicationinsights,
     python3-azure-mgmt-cdn, python3-azure-mgmt-security, python3-azure-
     identity, azure-cli, python3-azure-storage-common, python3-azure-
     synapse-managedprivateendpoints, python3-azure-mgmt-containerinstance,
     python3-azure-mgmt-trafficmanager, python3-azure-mgmt-web,
     python3-azure-mgmt-marketplaceordering, python3-azure-monitor-query,
     python3-azure-mgmt-hdinsight, python3-azure-mgmt-dns, python3-azure-
     mgmt-appconfiguration, python3-azure-synapse-spark, python3-azure-
     keyvault-secrets, python3-azure-mgmt-compute, python3-azure-mgmt-
     keyvault, python3-azure-mgmt-network, python3-azure-batch,
     python3-azure-mgmt-support, python3-azure-mgmt-recoveryservices,
     python3-azure-mgmt-recoveryservicesbackup, python3-azure-mgmt-sql,
     python3-azure-mgmt-datamigration, python3-azure-mgmt-appcontainers,
     python3-azure-mgmt-botservice, python3-azure-mgmt-authorization,
     python3-azure-mgmt-batchai, python3-azure-mgmt-loganalytics,
     python3-azure-datalake-store, python3-azure-mgmt-redhatopenshift,
     python3-azure-mgmt-maps, python3-azure-mgmt-subscription,
     python3-azure-mgmt-managedservices, python3-azure-mgmt-apimanagement,
     python3-azure-mgmt-managementgroups, python3-azure-mgmt-privatedns,
     python3-azure-data-tables, python3-azure-mgmt-billing, python3-azure-
     storage-blob, python3-azure-mgmt-iothub, python3-azure-keyvault-
     administration, python3-azure-mgmt-redis, python3-azure-mgmt-
     servicebus, python3-azure-mgmt-servicefabric, python3-azure-mgmt-
     cosmosdb, python3-azure-keyvault-keys, python3-azure-multiapi-storage,
     python3-azure-core, python3-azure-mgmt-cognitiveservices,
     python3-azure-cosmos, python3-azure-mgmt-advisor, python3-azure-mgmt-
     kusto, python3-azure-mgmt-signalr, python3-azure-graphrbac,
     python3-azure-mgmt-storage, python3-azure-mgmt-quota, python3-azure-
     mgmt-monitor, python3-azure-mgmt-eventgrid, python3-azure-mgmt-
     policyinsights, python3-azure-keyvault-certificates, python3-azure-
     mgmt-netapp, python3-azure-mgmt-eventhub, python3-azure-mgmt-rdbms,
     python3-azure-servicebus, python3-azure-mgmt-resource, python3-azure-
     synapse-artifacts, python3-azure-mgmt-core, python3-azure-mgmt-
     synapse), /usr/lib/python3.13/site-packages/azure/mgmt(python3-azure-
     mgmt-hdinsight, python3-azure-mgmt-managementgroups, python3-azure-
     mgmt-apimanagement, python3-azure-mgmt-iotcentral, python3-azure-mgmt-
     advisor, python3-azure-mgmt-privatedns, python3-azure-mgmt-search,
     python3-azure-mgmt-dns, python3-azure-mgmt-appconfiguration,
     python3-azure-mgmt-billing, python3-azure-mgmt-extendedlocation,
     python3-azure-mgmt-batch, python3-azure-mgmt-iothub, python3-azure-
     mgmt-databoxedge, python3-azure-mgmt-media, python3-azure-mgmt-
     containerservice, python3-azure-mgmt-compute, python3-azure-mgmt-
     kusto, python3-azure-mgmt-iothubprovisioningservices, python3-azure-
     mgmt-signalr, python3-azure-mgmt-redis, python3-azure-mgmt-servicebus,
     python3-azure-mgmt-servicefabric, python3-azure-mgmt-keyvault,
     python3-azure-mgmt-msi, python3-azure-mgmt-imagebuilder,
     python3-azure-mgmt-network, python3-azure-mgmt-storage, python3-azure-
     mgmt-servicelinker, python3-azure-mgmt-quota, python3-azure-mgmt-
     monitor, python3-azure-mgmt-servicefabricmanagedclusters,
     python3-azure-mgmt-eventgrid, python3-azure-mgmt-containerregistry,
     python3-azure-mgmt-devtestlabs, python3-azure-mgmt-policyinsights,
     python3-azure-mgmt-sqlvirtualmachine, python3-azure-mgmt-support,
     python3-azure-mgmt-maps, python3-azure-mgmt-cosmosdb, python3-azure-
     mgmt-netapp, python3-azure-mgmt-recoveryservices, python3-azure-mgmt-
     applicationinsights, python3-azure-mgmt-datamigration, python3-azure-
     mgmt-cdn, python3-azure-mgmt-recoveryservicesbackup, python3-azure-
     mgmt-eventhub, python3-azure-mgmt-appcontainers, python3-azure-mgmt-
     botservice, python3-azure-mgmt-security, python3-azure-mgmt-sql,
     python3-azure-mgmt-batchai, python3-azure-mgmt-authorization,
     python3-azure-mgmt-rdbms, python3-azure-mgmt-cognitiveservices,
     python3-azure-mgmt-resource, python3-azure-mgmt-containerinstance,
     python3-azure-mgmt-trafficmanager, python3-azure-mgmt-core,
     python3-azure-mgmt-loganalytics, python3-azure-mgmt-redhatopenshift,
     python3-azure-mgmt-web, python3-azure-mgmt-synapse, python3-azure-
     mgmt-marketplaceordering, python3-azure-mgmt-subscription,
     python3-azure-mgmt-managedservices)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2420 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-azure-mgmt-mysqlflexibleservers-1.0.0~b2-1.fc42.noarch.rpm
          python-azure-mgmt-mysqlflexibleservers-1.0.0~b2-1.fc42.src.rpm
===================================================================================== rpmlint session starts ====================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpzk_10h0u')]
checks: 32, packages: 2

python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/_patch.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/models/_patch.py
python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/__init__.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/__init__.py
=============================================== 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 11 filtered, 0 badness; has taken 0.5 s ===============================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/_patch.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/models/_patch.py
python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/__init__.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/__init__.py
 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.2 s



Source checksums
----------------
https://files.pythonhosted.org/packages/source/a/azure_mgmt_mysqlflexibleservers/azure_mgmt_mysqlflexibleservers-1.0.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : a4bdf3decfc7ece61a3e218d19d508ce8de9a69eac47f1beea20c1db5f4ca7d0
  CHECKSUM(SHA256) upstream package : a4bdf3decfc7ece61a3e218d19d508ce8de9a69eac47f1beea20c1db5f4ca7d0


Requires
--------
python3-azure-mgmt-mysqlflexibleservers (rpmlib, GLIBC filtered):
    python(abi)
    python3.13dist(azure-common)
    python3.13dist(azure-mgmt-core)
    python3.13dist(isodate)
    python3.13dist(typing-extensions)



Provides
--------
python3-azure-mgmt-mysqlflexibleservers:
    python-azure-mgmt-mysqlflexibleservers
    python3-azure-mgmt-mysqlflexibleservers
    python3.13-azure-mgmt-mysqlflexibleservers
    python3.13dist(azure-mgmt-mysqlflexibleservers)
    python3dist(azure-mgmt-mysqlflexibleservers)



Diff spec file in url and in SRPM
---------------------------------
--- /home/azureuser/2328742-python-azure-mgmt-mysqlflexibleservers/srpm/python-azure-mgmt-mysqlflexibleservers.spec     2024-12-16 19:24:16.185317162 +0000
+++ /home/azureuser/2328742-python-azure-mgmt-mysqlflexibleservers/srpm-unpacked/python-azure-mgmt-mysqlflexibleservers.spec    2024-11-25 00:00:00.000000000 +0000
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.7.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global         srcname         azure-mgmt-mysqlflexibleservers
 %global         tarball_name    azure_mgmt_mysqlflexibleservers
@@ -57,3 +67,6 @@

 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Nov 25 2024 John Doe <packager> - 1.0.0~b2-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2328742
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: R, Java, fonts, Haskell, Perl, SugarActivity, C/C++, PHP, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comment 3 Ben Beasley 2025-01-13 15:51:10 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== Notes =====

- The pyproject-rpm-macros are already correctly marking as %license the
  license file in the .dist-info directory via %{pyproject_files}, so you don’t
  have to install a duplicate copy manually.

    $ rpm -qL -p results/python3-azure-mgmt-postgresqlflexibleservers-1.1.0~b1-1.fc42.noarch.rpm 
    /usr/lib/python3.13/site-packages/azure_mgmt_postgresqlflexibleservers-1.1.0b1.dist-info/LICENSE
    /usr/share/licenses/python3-azure-mgmt-postgresqlflexibleservers/LICENSE
  
  You can remove
  
    %license LICENSE
  
  and change
  
    %pyproject_save_files azure
  
  to
  
    %pyproject_save_files -l azure
  
  to “assert” that a license file was included in the %{pyproject_files}; this
  guards against the license file “disappearing” in a future update, perhaps by
  upstream switching to a build backend that no longer sets the PEP 639
  License-File field.

- As a very minor nitpick, you might consider removing “This package has been
  tested with Python 3.8+.” from the description. Since people will only be
  using RPM packages with the system Python interpreter and can assume that
  it’s supported, it’s not really useful information.

- A newer version, 1.1.0b3, is available. Furthermore, I would normally
  discourage packaging a pre-release without adequate justification. Knowing
  that Azure CLI tends to impose strict version requirements on its
  dependencies, I assume the choice of 1.1.0b2 is well-justified in this case.

- While rpmlint warns about duplicate files, these are trivial Python source
  files that happen to be identical, and I don’t recommend trying to do
  anything about that. (If you hardlinked them, very little space would be
  saved, and rpm would complain about cross-directory hardlinks instead, since
  in the general case different directories may be on different filesystems.) 

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 14 files have unknown license. Detailed output of
     licensecheck in /home/ben/fedora/review/2328742-python-azure-mgmt-
     mysqlflexibleservers/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13/site-
     packages, /usr/lib/python3.13

     Spurious diagnostic; owned by python3-libs.

[-]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.13/site-
     packages/azure(python3-azure-mgmt-quota, python3-azure-mgmt-cdn,
     python3-azure-mgmt-netapp, python3-azure-storage-blob, python3-azure-
     data-tables, python3-azure-mgmt-containerregistry, python3-azure-
     multiapi-storage, python3-azure-appconfiguration, python3-azure-
     keyvault-administration, python3-azure-mgmt-maps, python3-azure-ai-
     textanalytics, python3-azure-mgmt-databoxedge, python3-azure-mgmt-
     trafficmanager, python3-azure-synapse-artifacts, python3-azure-mgmt-
     security, python3-azure-mgmt-applicationinsights, python3-azure-mgmt-
     sql, python3-azure-mgmt-subscription, python3-azure-mgmt-msi,
     python3-azure-mgmt-marketplaceordering, python3-azure-mgmt-keyvault,
     python3-azure-mgmt-cosmosdb, python3-azure-mgmt-billing,
     python3-azure-synapse-accesscontrol, python3-azure-mgmt-eventhub,
     python3-azure-mgmt-botservice, python3-azure-mgmt-core, python3-azure-
     mgmt-appconfiguration, python3-azure-mgmt-advisor, python3-azure-mgmt-
     recoveryservicesbackup, python3-azure-mgmt-sqlvirtualmachine,
     python3-azure-cosmos, python3-azure-mgmt-support, python3-azure-
     datalake-store, python3-azure-mgmt-batch, python3-azure-mgmt-signalr,
     python3-azure-mgmt-search, python3-azure-mgmt-monitor, python3-azure-
     mgmt-resource, python3-azure-mgmt-iothub, python3-azure-mgmt-web,
     python3-azure-monitor-query, python3-azure-mgmt-batchai,
     python3-azure-mgmt-dns, python3-azure-mgmt-apimanagement,
     python3-azure-common, python3-azure-mgmt-iothubprovisioningservices,
     python3-azure-mgmt-servicefabric, python3-azure-mgmt-privatedns,
     python3-azure-mgmt-compute, python3-azure-mgmt-servicebus,
     python3-azure-mgmt-iotcentral, python3-azure-mgmt-managedservices,
     python3-azure-mgmt-recoveryservices, python3-azure-ai-formrecognizer,
     python3-azure-mgmt-synapse, python3-azure-core, python3-azure-mgmt-
     rdbms, azure-cli, python3-azure-mgmt-containerinstance, python3-azure-
     identity, python3-azure-keyvault-keys, python3-azure-mgmt-
     extendedlocation, python3-azure-mgmt-hdinsight, python3-azure-
     keyvault-secrets, python3-azure-mgmt-kusto, python3-azure-mgmt-
     network, python3-azure-mgmt-loganalytics, python3-azure-graphrbac,
     python3-azure-storage-common, python3-azure-mgmt-appcontainers,
     python3-azure-synapse-managedprivateendpoints, python3-azure-mgmt-
     datamigration, python3-azure-mgmt-storage, python3-azure-servicebus,
     python3-azure-mgmt-redis, python3-azure-mgmt-media, python3-azure-
     batch, python3-azure-mgmt-servicelinker, python3-azure-mgmt-
     containerservice, python3-azure-mgmt-eventgrid, python3-azure-synapse-
     spark, python3-azure-mgmt-cognitiveservices, python3-azure-mgmt-
     policyinsights, python3-azure-mgmt-servicefabricmanagedclusters,
     python3-azure-keyvault-certificates, python3-azure-mgmt-
     managementgroups, python3-azure-mgmt-imagebuilder, python3-azure-mgmt-
     redhatopenshift, python3-azure-mgmt-authorization, python3-azure-mgmt-
     devtestlabs), /usr/lib/python3.13/site-
     packages/azure/mgmt(python3-azure-mgmt-kusto, python3-azure-mgmt-
     quota, python3-azure-mgmt-iothubprovisioningservices, python3-azure-
     mgmt-keyvault, python3-azure-mgmt-cosmosdb, python3-azure-mgmt-cdn,
     python3-azure-mgmt-network, python3-azure-mgmt-servicefabric,
     python3-azure-mgmt-loganalytics, python3-azure-mgmt-privatedns,
     python3-azure-mgmt-billing, python3-azure-mgmt-eventhub,
     python3-azure-mgmt-compute, python3-azure-mgmt-servicebus,
     python3-azure-mgmt-netapp, python3-azure-mgmt-appcontainers,
     python3-azure-mgmt-iotcentral, python3-azure-mgmt-botservice,
     python3-azure-mgmt-datamigration, python3-azure-mgmt-core,
     python3-azure-mgmt-managedservices, python3-azure-mgmt-
     containerregistry, python3-azure-mgmt-recoveryservices, python3-azure-
     mgmt-appconfiguration, python3-azure-mgmt-advisor, python3-azure-mgmt-
     recoveryservicesbackup, python3-azure-mgmt-sqlvirtualmachine,
     python3-azure-mgmt-storage, python3-azure-mgmt-redis, python3-azure-
     mgmt-media, python3-azure-mgmt-synapse, python3-azure-mgmt-maps,
     python3-azure-mgmt-rdbms, python3-azure-mgmt-support, python3-azure-
     mgmt-containerinstance, python3-azure-mgmt-batch, python3-azure-mgmt-
     databoxedge, python3-azure-mgmt-servicelinker, python3-azure-mgmt-
     trafficmanager, python3-azure-mgmt-signalr, python3-azure-mgmt-
     containerservice, python3-azure-mgmt-eventgrid, python3-azure-mgmt-
     search, python3-azure-mgmt-monitor, python3-azure-mgmt-security,
     python3-azure-mgmt-resource, python3-azure-mgmt-iothub, python3-azure-
     mgmt-applicationinsights, python3-azure-mgmt-sql, python3-azure-mgmt-
     web, python3-azure-mgmt-cognitiveservices, python3-azure-mgmt-
     policyinsights, python3-azure-mgmt-servicefabricmanagedclusters,
     python3-azure-mgmt-subscription, python3-azure-mgmt-batchai,
     python3-azure-mgmt-msi, python3-azure-mgmt-managementgroups,
     python3-azure-mgmt-dns, python3-azure-mgmt-extendedlocation,
     python3-azure-mgmt-hdinsight, python3-azure-mgmt-imagebuilder,
     python3-azure-mgmt-marketplaceordering, python3-azure-mgmt-
     redhatopenshift, python3-azure-mgmt-apimanagement, python3-azure-mgmt-
     authorization, python3-azure-mgmt-devtestlabs)

     Co-owning the directories /usr/lib/python3.13/site-packages/azure and
     /usr/lib/python3.13/site-packages/azure/mgmt, which correspond to Python
     namespace packages, is appropriate and consistent with
     https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2420 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.

     No tests are included in the PyPI sdist. This could possibly be resolved
     by packaging from the GitHub archive, but that would be the entire Azure
     SDK for Python, which is probably unreasonable.

[!]: Latest version is packaged.

     A newer version, 1.1.0b3, is available. Furthermore, I would normally
     discourage packaging a pre-release without adequate justification.

[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

     https://koji.fedoraproject.org/koji/taskinfo?taskID=127834935

[-]: %check is present and all tests pass.

     No tests are included in the PyPI sdist. This could possibly be resolved
     by packaging from the GitHub archive, but that would be the entire Azure
     SDK for Python, which is probably unreasonable.

     The %check section contains an appropriate “smoke test.”

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-azure-mgmt-mysqlflexibleservers-1.0.0~b2-1.fc42.noarch.rpm
          python-azure-mgmt-mysqlflexibleservers-1.0.0~b2-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_xn9uqe5')]
checks: 32, packages: 2

python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/_patch.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/models/_patch.py
python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/__init__.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/__init__.py
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.4 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/_patch.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/_patch.py:/usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/models/_patch.py
python3-azure-mgmt-mysqlflexibleservers.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/operations/__init__.py /usr/lib/python3.13/site-packages/azure/mgmt/mysqlflexibleservers/aio/operations/__init__.py
 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.2 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/a/azure_mgmt_mysqlflexibleservers/azure_mgmt_mysqlflexibleservers-1.0.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : a4bdf3decfc7ece61a3e218d19d508ce8de9a69eac47f1beea20c1db5f4ca7d0
  CHECKSUM(SHA256) upstream package : a4bdf3decfc7ece61a3e218d19d508ce8de9a69eac47f1beea20c1db5f4ca7d0


Requires
--------
python3-azure-mgmt-mysqlflexibleservers (rpmlib, GLIBC filtered):
    python(abi)
    python3.13dist(azure-common)
    python3.13dist(azure-mgmt-core)
    python3.13dist(isodate)
    python3.13dist(typing-extensions)



Provides
--------
python3-azure-mgmt-mysqlflexibleservers:
    python-azure-mgmt-mysqlflexibleservers
    python3-azure-mgmt-mysqlflexibleservers
    python3.13-azure-mgmt-mysqlflexibleservers
    python3.13dist(azure-mgmt-mysqlflexibleservers)
    python3dist(azure-mgmt-mysqlflexibleservers)



Diff spec file in url and in SRPM
---------------------------------
--- /home/ben/fedora/review/2328742-python-azure-mgmt-mysqlflexibleservers/srpm/python-azure-mgmt-mysqlflexibleservers.spec	2025-01-13 10:32:36.828095976 -0500
+++ /home/ben/fedora/review/2328742-python-azure-mgmt-mysqlflexibleservers/srpm-unpacked/python-azure-mgmt-mysqlflexibleservers.spec	2024-11-24 19:00:00.000000000 -0500
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.7.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global         srcname         azure-mgmt-mysqlflexibleservers
 %global         tarball_name    azure_mgmt_mysqlflexibleservers
@@ -57,3 +67,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Nov 25 2024 John Doe <packager> - 1.0.0~b2-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2328742
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: C/C++, fonts, Ocaml, Java, Perl, R, PHP, Haskell, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comment 4 Fedora Admin user for bugzilla script actions 2025-01-13 16:23:10 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-mgmt-mysqlflexibleservers