Bug 2329142 (rust-x509-cert)

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8318720
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329142-rust-x509-cert/fedora-rawhide-x86_64/08318720-rust-x509-cert/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks like the links have expired? The SRPM link gives me an HTTP 404 error now.

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-x509-cert/rust-x509-cert.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/fedora-rawhide-x86_64/08576951-rust-x509-cert/rust-x509-cert-0.2.5-1.fc42.src.rpm
Description: Pure Rust implementation of the X.509 PKI Certificate format from RFC 5280
Fedora Account System Username: elmarco

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8576974
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329142-rust-x509-cert/fedora-rawhide-x86_64/08576974-rust-x509-cert/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks mostly good to me, with two small caveats:

- Can you add comments to the spec file for what you're patching?
  Something like this would be enough:

"""
# * drop unused sct feature / tls_codec dependency
# * bump rstest dev-dependency from 0.18 to 0.23
"""

- There's some amount of test data that aren't useful in the built package.
  You could exclude it by adding the following to the "%files devel" list:

"""
%exclude %{crate_instdir}/tests/examples/
"""

Both (and the Summary override) could be automated with a rust2rpm.toml config snippet:

"""
[package]
summary = "Pure Rust implementation of the X.509 PKI Certificate format from RFC 5280"
cargo-toml-patch-comments = [
    "drop unused sct feature / tls_codec dependency",
    "bump rstest dev-dependency from 0.18 to 0.23",
]
exclude-crate-files = [
    "tests/examples/",
]
"""

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-x509-cert/rust-x509-cert.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08577378/rust-x509-cert-0.2.5-1.src.rpm
Description: Pure Rust implementation of the X.509 PKI Certificate format from RFC 5280
Fedora Account System Username: elmarco

Created attachment 2073998 [details]
The .spec file difference from Copr build 8576974 to 8577408

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8577408
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329142-rust-x509-cert/fedora-rawhide-x86_64/08577408-rust-x509-cert/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x509-cert

FEDORA-2025-6b4029a319 (rust-x509-cert-0.2.5-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6b4029a319

FEDORA-2025-6b4029a319 (rust-x509-cert-0.2.5-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.