Bug 2329823
| Summary: | Review Request: GENie - Project generator tool | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> | ||||
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | negativo17, package-review | ||||
| Target Milestone: | --- | Flags: | negativo17:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/bkaradzic/GENie | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-01-11 01:25:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Benson Muite
2024-12-02 08:49:40 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8332924 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329823-genie/fedora-rawhide-x86_64/08332924-GENie/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. 1) Please drop the first block, is not needed at all:
## START: Set by rpmautospec
## (rpmautospec version 0.7.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 1;
base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
print(release_number + base_release_number - 1);
}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
## END: Set by rpmautospec
2) Please adjust version, since you are already declaring commit/date/shortcommit, use them in the version field.
Version: 1181^%{date}.%{shortcommit}
3) Please pass "-p" to install commands in the install section. You can also squeeze in one line omitting mkdir:
install -p -m 755 bin/linux/genie %{buildroot}%{_bindir}/genie
4) In the %changelog section, remove everything and just use %autochangelog to have the changelog automatically populated with git commit messages:
%changelog
%autochangelog
Btw, since the project does not provide any tag or release, you might as want package the latest snapshot which is at version 1187. Thanks. Thanks for the feedback. Addressed all comments and updated. Spec URL: https://fed500.fedorapeople.org/GENie.spec SRPM URL: https://fed500.fedorapeople.org/GENie-1187^20241207.93f6621-1.fc42.src.rpm There seems to be some problem with the following file. SRPM URL: https://fed500.fedorapeople.org/GENie-1187%5E20241207.93f6621-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2064161 [details]
The .spec file difference from Copr build 8332924 to 8453995
Copr build: https://copr.fedorainfracloud.org/coprs/build/8453995 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329823-genie/fedora-rawhide-x86_64/08453995-GENie/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/GENie Thanks for the review. FEDORA-2025-fe353b50ec (GENie-1187^20241207.93f6621-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-fe353b50ec FEDORA-2025-5096ebaac7 (GENie-1187^20241207.93f6621-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5096ebaac7 FEDORA-2025-fe353b50ec has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fe353b50ec \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fe353b50ec See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-5096ebaac7 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-5096ebaac7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-5096ebaac7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-fe353b50ec (GENie-1187^20241207.93f6621-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-5096ebaac7 (GENie-1187^20241207.93f6621-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |