Bug 2330141

Summary: Missing dependency: which
Product: [Fedora] Fedora Reporter: Vladislav Grigoryev <vg.aetera>
Component: tigervncAssignee: Jan Grulich <jgrulich>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 41CC: jgrulich, vg.aetera
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: tigervnc-1.14.1-3.fc41 tigervnc-1.14.1-3.fc40 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-01-01 04:38:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladislav Grigoryev 2024-12-03 10:09:24 UTC
Missing dependency: which
The which command/package is required by tigervnc-server:
```
> grep -e which /usr/libexec/vncsession-restore
MATCHPATHCON=`which matchpathcon`
RESTORECON=`which restorecon`

> rpm -q -f /usr/libexec/vncsession-restore
tigervnc-server-1.14.1-2.fc41.x86_64
```

Reproducible: Always

Comment 1 Fedora Update System 2024-12-19 09:16:57 UTC
FEDORA-2024-e2495e93cd (tigervnc-1.14.1-3.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e2495e93cd

Comment 2 Fedora Update System 2024-12-20 04:36:43 UTC
FEDORA-2024-2cf0b95263 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2cf0b95263`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2cf0b95263

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Vladislav Grigoryev 2024-12-20 05:54:40 UTC
The base `tigervnc` package does not require this dependency.
It should be added only for the `tigervnc-server` package here:
https://src.fedoraproject.org/rpms/tigervnc/blob/5bbad1a4756ccceceb2e3026182cb4379a4afb51/f/tigervnc.spec#_112-116

Comment 4 Fedora Update System 2024-12-20 05:58:55 UTC
FEDORA-2024-e2495e93cd has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e2495e93cd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e2495e93cd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2024-12-25 01:50:16 UTC
FEDORA-2024-2cf0b95263 (tigervnc-1.14.1-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Vladislav Grigoryev 2024-12-29 11:13:18 UTC
Sorry, but the issue persists.
The dependency was added to the wrong place.
To be clear, `which` is required by `tigervnc-server`, not `tigervnc`.
The specfile should be patched like this:
```
diff --git a/tigervnc.spec b/tigervnc.spec
index 1a7b7f5..da2cc32 100644
--- a/tigervnc.spec
+++ b/tigervnc.spec
@@ -97,7 +97,6 @@ Requires(postun):coreutils
 Requires:       hicolor-icon-theme
 Requires:       tigervnc-license
 Requires:       tigervnc-icons
-Requires:       which
 
 %description
 Virtual Network Computing (VNC) is a remote display system which
@@ -114,6 +113,7 @@ Requires:       tigervnc-server-minimal = %{version}-%{release}
 Requires:       (%{name}-selinux if selinux-policy-%{selinuxtype})
 Requires:       xorg-x11-xauth
 Requires:       xorg-x11-xinit
+Requires:       which
 Requires(post): systemd
 Requires(preun): systemd
 Requires(postun): systemd
```

Comment 7 Fedora Update System 2025-01-01 04:38:23 UTC
FEDORA-2024-e2495e93cd (tigervnc-1.14.1-3.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.