Bug 2331035

Summary:	Review Request: qrca - QR code scanner for KDE Plasma
Product:	[Fedora] Fedora	Reporter:	Steve Cossette <farchord>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	ngompa13: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://apps.kde.org/qrca/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-08 21:04:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Steve Cossette 2024-12-08 19:48:32 UTC

Spec URL: https://farchord.fedorapeople.org/reviews/qrca/qrca.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/qrca/qrca-1.0.0~20241206.203647.da129cc-1.fc41.src.rpm

Description:
Qrca is a simple application for Plasma Desktop
and Plasma Mobile that lets you scan many barcode
formats and create your own QR code images.

Fedora Account System Username: farchord

Comment 1 Fedora Review Service 2024-12-08 19:59:45 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8364136
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2331035-qrca/fedora-rawhide-x86_64/08364136-qrca/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-12-08 20:44:43 UTC

Initial review notes:

> Version:       1.0.0~%{gitdate}.%{shortcommit}

CMake says the version is "0.1", not "1.0.0".

Comment 3 Steve Cossette 2024-12-08 20:47:48 UTC

Spec URL: https://farchord.fedorapeople.org/reviews/qrca/qrca.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/qrca/qrca-0.1~20241206.203647.da129cc-1.fc41.src.rpm

Fixed version

Comment 4 Neal Gompa 2024-12-08 20:49:54 UTC

Review notes:

* Package builds and installs
* Package follows Fedora KDE packaging guidelines
* Package licensing is correct and license data is correctly installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Steve Cossette 2024-12-08 20:51:16 UTC

Thank you for the review, Neal

Comment 6 Fedora Admin user for bugzilla script actions 2024-12-08 20:51:30 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/qrca