Bug 2331910
Summary: | Review Request: topgrade - Upgrade all the things | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | LILAY <lilaychhou> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, solomoncyj |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/topgrade-rs/topgrade | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | --- | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | --- | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
LILAY
2024-12-12 02:12:22 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/lilay/topgrade/fedora-41-x86_64/08381001-topgrade/topgrade.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lilay/topgrade/fedora-41-x86_64/08381001-topgrade/topgrade-16.0.2-1.fc41.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8381121 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2331910-topgrade/fedora-rawhide-x86_64/08381121-topgrade/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. As for my build It need network access because of "cargo build" command need to downloading config.json from index.crates.io. While on local build I use "fedpkg --release f41 mockbuild --enable-network" and on copr I can enable network. uou need to use rust2rpm. install it from dnf and run `rust2rpm topgrade` and upload the files here Thank you so much I didn't know about rust2rpm. Here's what genereated. Spec: https://drive.google.com/file/d/1_MW8BtwQ0YjfptYKH4iW3DhrPgjs7n9b/view?usp=sharing Diff: https://drive.google.com/file/d/1tDg1LTL2cWoQmmuyTZk79ksQ16ZCN-0m/view?usp=sharing plese inmstal cargo-licenses and concatnate all license found like this : (...) AND (...) ... and put it under %licenses. also put the source licenses under %sourcelicense Thank for your further guidance. Sorry I don't quite get what you mean but here the new changes: Spec: https://paste.lilay.dev/?bdec4df4e31250c7#BHY8j74H8KMN3MBuinLVEp8kGpsFUqQ5wPo3J12Xj12K You mean something like this? Here the output after I ran 'cargo license': Output: https://paste.lilay.dev/?ae0acb4ff99c9057#AXHGrwRhhb2QqcsNTfP3rj2rMwe4F4P97wgixvriMaoU Do you need to specify the 'OR' and 'WITH' too with all the licenses? And liecenses Duplication? # INGORE ALL THAT THE REPO IS SET TO ARCHIVE AND IN THE WORDS OF THE AUTHORS: THE CRATE IS NO LONGER MANTINED: https://github.com/r-darwish/topgrade THIS CRATE **SHOULD NOT** BE PACKAGED wrong, wrong wrong, remove %licenses and set License: (MIT OR Apache-2.0) AND Unicode-3.0) AND (0BSD OR Apache-2.0 OR MIT) AND (Apache-2.0 OR Apache-2.0 WITH LLVM-exception OR MIT) AND (Apache-2.0 OR BSD-2-Clause OR MIT) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Apache-2.0 OR MIT OR Zlib) AND (CC0-1.0) AND (GPL-3.0) AND (MIT) AND (MIT OR Unlicense) AND (MPL-2.0) SourceLicense should be GPL-3.0-or-later ignor the above comment. upstream is https://github.com/topgrade-rs/topgrade which is a fork of https://github.com/r-darwish/topgrade Yes it's a fork repo! I have made some changes. Spec: https://paste.lilay.dev/?8b52d60b75446083#E1QBZEBEitfswKqj4gZ66agHo3qg1QifZqn8g98h1w5s now uplod to copr and post sources Build failed on Copr, I tried to build local but got no where: Copr build log: https://paste.lilay.dev/?40dfd5447e8e8002#He773oZTTyAb5RaiifDURpsWgvwuyTNCC4h5LD6TyDbZ Should I use log detective? |